Bug 226460

Summary: MediaSessionCoordinator API test is failing,
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226328    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Jean-Yves Avenard [:jya] 2021-05-31 01:26:13 PDT
The test TestWebKitAPI.MediaSessionCoordinatorTest.StateChanges fails with the error:
```
       /Users/jyavenard/Work/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:468
        Expected equality of these values:
          "coordinatorStateChanged"
          lastStateChange.utf8().data()
            Which is: ""
        
```

This is a regression from bug 225822.

the test expects that there will be a callback to coordinatorStateChange when MediaSessionCoordinatorPrivate::leave() is called which is no longer the case.
Comment 1 Radar WebKit Bug Importer 2021-05-31 01:26:36 PDT
<rdar://problem/78680005>
Comment 2 youenn fablet 2021-06-01 04:36:02 PDT
*** Bug 226459 has been marked as a duplicate of this bug. ***
Comment 3 Jean-Yves Avenard [:jya] 2021-06-02 01:14:38 PDT
Created attachment 430324 [details]
Patch
Comment 4 Eric Carlson 2021-06-02 09:43:31 PDT
Comment on attachment 430324 [details]
Patch

Windows failure is unrelated.
Comment 5 EWS 2021-06-02 10:07:10 PDT
Committed r278363 (238393@main): <https://commits.webkit.org/238393@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430324 [details].