Bug 226460

Summary: MediaSessionCoordinator API test is failing,
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 226328    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jean-Yves Avenard [:jya]
Reported 2021-05-31 01:26:13 PDT
The test TestWebKitAPI.MediaSessionCoordinatorTest.StateChanges fails with the error: ``` /Users/jyavenard/Work/webkit/OpenSource/Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:468 Expected equality of these values: "coordinatorStateChanged" lastStateChange.utf8().data() Which is: "" ``` This is a regression from bug 225822. the test expects that there will be a callback to coordinatorStateChange when MediaSessionCoordinatorPrivate::leave() is called which is no longer the case.
Attachments
Patch (2.21 KB, patch)
2021-06-02 01:14 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-31 01:26:36 PDT
<rdar://problem/78680005>
youenn fablet
Comment 2 2021-06-01 04:36:02 PDT
*** Bug 226459 has been marked as a duplicate of this bug. ***
Jean-Yves Avenard [:jya]
Comment 3 2021-06-02 01:14:38 PDT
Created attachment 430324 [details] Patch
Eric Carlson
Comment 4 2021-06-02 09:43:31 PDT
Comment on attachment 430324 [details] Patch Windows failure is unrelated.
EWS
Comment 5 2021-06-02 10:07:10 PDT
Committed r278363 (238393@main): <https://commits.webkit.org/238393@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430324 [details].
Note You need to log in before you can comment on or make changes to this bug.