Bug 226445

Summary: Drop PendingActivity data member from BaseAudioContext
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-05-30 19:25:36 PDT 
Drop PendingActivity data member from BaseAudioContext and instead have AudioContext / OfflineAudioContext override virtualHasPendingActivity() to keep their JS wrapper alive. I find that PendingActivity data members are too error prone and a frequent cause of leaks.
Comment 1 Chris Dumez 2021-05-30 19:27:28 PDT 
Created attachment 430163 [details]
Patch
Comment 2 Chris Dumez 2021-05-30 19:29:03 PDT 
Created attachment 430164 [details]
Patch
Comment 3 EWS 2021-05-31 17:08:27 PDT 
Committed r278288 (238325@main): <https://commits.webkit.org/238325@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430164 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-31 17:09:17 PDT 
<rdar://problem/78695343>