Summary: | Remove <wtf/Optional.h> | ||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||||||||||
Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
Severity: | Normal | CC: | alecflett, annulen, bburg, beidson, benjamin, berto, calvaris, cdumez, cgarcia, changseok, cmarcelo, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jbedard, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, ryuan.choi, saam, sabouhallawa, schenney, sergio, simon.fraser, tommyw, tonikitoo, tzagallo, vjaquez, webkit-bug-importer, youennf | ||||||||||||||||||||||||
Priority: | P3 | Keywords: | InRadar | ||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
Hardware: | All | ||||||||||||||||||||||||||
OS: | All | ||||||||||||||||||||||||||
Bug Depends on: | 226433 | ||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||
Attachments: |
|
Description
Darin Adler
2021-05-30 12:05:34 PDT
Created attachment 430148 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Created attachment 430149 [details]
Patch
Created attachment 430155 [details]
Patch
Created attachment 430157 [details]
Patch
Created attachment 430166 [details]
Patch
Created attachment 430214 [details]
Patch
Created attachment 430225 [details]
Patch
Created attachment 430294 [details]
Patch
Created attachment 430305 [details]
Patch
Created attachment 430313 [details]
Patch
Created attachment 430315 [details]
Patch
Comment on attachment 430315 [details]
Patch
r=me
Comment on attachment 430315 [details]
Patch
r=me
Committed r278340 (238372@main): <https://commits.webkit.org/238372@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430315 [details]. |