Bug 226437

Summary:

Remove <wtf/Optional.h>

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, bburg, beidson, benjamin, berto, calvaris, cdumez, cgarcia, changseok, cmarcelo, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jbedard, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, ryuan.choi, saam, sabouhallawa, schenney, sergio, simon.fraser, tommyw, tonikitoo, tzagallo, vjaquez, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

226433

Bug Blocks:

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Darin Adler

Reported 2021-05-30 12:05:34 PDT

Remove <wtf/Optional.h>

Attachments
Patch (262.83 KB, patch) 2021-05-30 13:31 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (263.98 KB, patch) 2021-05-30 13:49 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (265.61 KB, patch) 2021-05-30 16:59 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (266.64 KB, patch) 2021-05-30 17:16 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (267.32 KB, patch) 2021-05-30 19:40 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (268.17 KB, patch) 2021-05-31 16:25 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (268.13 KB, patch) 2021-05-31 19:34 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (269.39 KB, patch) 2021-06-01 14:56 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (269.39 KB, patch) 2021-06-01 17:01 PDT, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (268.54 KB, patch) 2021-06-01 18:34 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (268.53 KB, patch) 2021-06-01 21:00 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2021-05-30 13:31:42 PDT Comment hidden (obsolete)

Created attachment 430148 [details] Patch

EWS Watchlist

Comment 2 2021-05-30 13:32:40 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Darin Adler

Comment 3 2021-05-30 13:49:41 PDT Comment hidden (obsolete)

Created attachment 430149 [details] Patch

Darin Adler

Comment 4 2021-05-30 16:59:43 PDT Comment hidden (obsolete)

Created attachment 430155 [details] Patch

Darin Adler

Comment 5 2021-05-30 17:16:50 PDT Comment hidden (obsolete)

Created attachment 430157 [details] Patch

Darin Adler

Comment 6 2021-05-30 19:40:31 PDT Comment hidden (obsolete)

Created attachment 430166 [details] Patch