Bug 226437

Summary: Remove <wtf/Optional.h>
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, bburg, beidson, benjamin, berto, calvaris, cdumez, cgarcia, changseok, cmarcelo, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jbedard, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, ryuan.choi, saam, sabouhallawa, schenney, sergio, simon.fraser, tommyw, tonikitoo, tzagallo, vjaquez, webkit-bug-importer, youennf
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 226433    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Darin Adler 2021-05-30 12:05:34 PDT
Remove <wtf/Optional.h>
Comment 1 Darin Adler 2021-05-30 13:31:42 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2021-05-30 13:32:40 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Darin Adler 2021-05-30 13:49:41 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2021-05-30 16:59:43 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2021-05-30 17:16:50 PDT Comment hidden (obsolete)
Comment 6 Darin Adler 2021-05-30 19:40:31 PDT Comment hidden (obsolete)
Comment 7 Darin Adler 2021-05-31 16:25:58 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2021-05-31 19:34:43 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2021-06-01 14:56:24 PDT Comment hidden (obsolete)
Comment 10 Darin Adler 2021-06-01 17:01:01 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2021-06-01 18:34:40 PDT Comment hidden (obsolete)
Comment 12 Darin Adler 2021-06-01 21:00:22 PDT
Created attachment 430315 [details]
Patch
Comment 13 Chris Dumez 2021-06-01 22:06:23 PDT
Comment on attachment 430315 [details]
Patch

r=me
Comment 14 Chris Dumez 2021-06-01 22:06:33 PDT
Comment on attachment 430315 [details]
Patch

r=me
Comment 15 EWS 2021-06-01 23:46:03 PDT
Committed r278340 (238372@main): <https://commits.webkit.org/238372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430315 [details].
Comment 16 Radar WebKit Bug Importer 2021-06-01 23:47:16 PDT
<rdar://problem/78750254>