WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226437
Remove <wtf/Optional.h>
https://bugs.webkit.org/show_bug.cgi?id=226437
Summary
Remove <wtf/Optional.h>
Darin Adler
Reported
2021-05-30 12:05:34 PDT
Remove <wtf/Optional.h>
Attachments
Patch
(262.83 KB, patch)
2021-05-30 13:31 PDT
,
Darin Adler
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(263.98 KB, patch)
2021-05-30 13:49 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(265.61 KB, patch)
2021-05-30 16:59 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(266.64 KB, patch)
2021-05-30 17:16 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(267.32 KB, patch)
2021-05-30 19:40 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(268.17 KB, patch)
2021-05-31 16:25 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(268.13 KB, patch)
2021-05-31 19:34 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(269.39 KB, patch)
2021-06-01 14:56 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(269.39 KB, patch)
2021-06-01 17:01 PDT
,
Darin Adler
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(268.54 KB, patch)
2021-06-01 18:34 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(268.53 KB, patch)
2021-06-01 21:00 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Show Obsolete
(10)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2021-05-30 13:31:42 PDT
Comment hidden (obsolete)
Created
attachment 430148
[details]
Patch
EWS Watchlist
Comment 2
2021-05-30 13:32:40 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Darin Adler
Comment 3
2021-05-30 13:49:41 PDT
Comment hidden (obsolete)
Created
attachment 430149
[details]
Patch
Darin Adler
Comment 4
2021-05-30 16:59:43 PDT
Comment hidden (obsolete)
Created
attachment 430155
[details]
Patch
Darin Adler
Comment 5
2021-05-30 17:16:50 PDT
Comment hidden (obsolete)
Created
attachment 430157
[details]
Patch
Darin Adler
Comment 6
2021-05-30 19:40:31 PDT
Comment hidden (obsolete)
Created
attachment 430166
[details]
Patch
Darin Adler
Comment 7
2021-05-31 16:25:58 PDT
Comment hidden (obsolete)
Created
attachment 430214
[details]
Patch
Darin Adler
Comment 8
2021-05-31 19:34:43 PDT
Comment hidden (obsolete)
Created
attachment 430225
[details]
Patch
Darin Adler
Comment 9
2021-06-01 14:56:24 PDT
Comment hidden (obsolete)
Created
attachment 430294
[details]
Patch
Darin Adler
Comment 10
2021-06-01 17:01:01 PDT
Comment hidden (obsolete)
Created
attachment 430305
[details]
Patch
Darin Adler
Comment 11
2021-06-01 18:34:40 PDT
Comment hidden (obsolete)
Created
attachment 430313
[details]
Patch
Darin Adler
Comment 12
2021-06-01 21:00:22 PDT
Created
attachment 430315
[details]
Patch
Chris Dumez
Comment 13
2021-06-01 22:06:23 PDT
Comment on
attachment 430315
[details]
Patch r=me
Chris Dumez
Comment 14
2021-06-01 22:06:33 PDT
Comment on
attachment 430315
[details]
Patch r=me
EWS
Comment 15
2021-06-01 23:46:03 PDT
Committed
r278340
(
238372@main
): <
https://commits.webkit.org/238372@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 430315
[details]
.
Radar WebKit Bug Importer
Comment 16
2021-06-01 23:47:16 PDT
<
rdar://problem/78750254
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug