Bug 226437 - Remove <wtf/Optional.h>
Summary: Remove <wtf/Optional.h>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on: 226433
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-30 12:05 PDT by Darin Adler
Modified: 2021-06-01 23:47 PDT (History)
57 users (show)

See Also:

Attachments
Patch (262.83 KB, patch)
2021-05-30 13:31 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (263.98 KB, patch)
2021-05-30 13:49 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (265.61 KB, patch)
2021-05-30 16:59 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (266.64 KB, patch)
2021-05-30 17:16 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (267.32 KB, patch)
2021-05-30 19:40 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (268.17 KB, patch)
2021-05-31 16:25 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (268.13 KB, patch)
2021-05-31 19:34 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (269.39 KB, patch)
2021-06-01 14:56 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (269.39 KB, patch)
2021-06-01 17:01 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (268.54 KB, patch)
2021-06-01 18:34 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (268.53 KB, patch)
2021-06-01 21:00 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-05-30 12:05:34 PDT 
Remove <wtf/Optional.h>
Comment 1 Darin Adler 2021-05-30 13:31:42 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2021-05-30 13:32:40 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Darin Adler 2021-05-30 13:49:41 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2021-05-30 16:59:43 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2021-05-30 17:16:50 PDT Comment hidden (obsolete)
Comment 6 Darin Adler 2021-05-30 19:40:31 PDT Comment hidden (obsolete)
Comment 7 Darin Adler 2021-05-31 16:25:58 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2021-05-31 19:34:43 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2021-06-01 14:56:24 PDT Comment hidden (obsolete)
Comment 10 Darin Adler 2021-06-01 17:01:01 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2021-06-01 18:34:40 PDT Comment hidden (obsolete)
Comment 12 Darin Adler 2021-06-01 21:00:22 PDT 
Created attachment 430315 [details]
Patch
Comment 13 Chris Dumez 2021-06-01 22:06:23 PDT 
Comment on attachment 430315 [details]
Patch

r=me
Comment 14 Chris Dumez 2021-06-01 22:06:33 PDT 
Comment on attachment 430315 [details]
Patch

r=me
Comment 15 EWS 2021-06-01 23:46:03 PDT 
Committed r278340 (238372@main): <https://commits.webkit.org/238372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430315 [details].
Comment 16 Radar WebKit Bug Importer 2021-06-01 23:47:16 PDT 
<rdar://problem/78750254>