Bug 226435

Summary:

[LFC] Tighten the constraint classes (ConstraintsForInFlowContent/ConstraintsForOutOfFlowContent)

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
[fast-cq] Patch	none

zalan

Reported 2021-05-30 06:57:58 PDT

ssia

Attachments
Patch (30.41 KB, patch) 2021-05-30 07:07 PDT, zalan	no flags	Details Formatted Diff Diff
Patch (59.10 KB, patch) 2021-05-31 16:54 PDT, zalan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (67.08 KB, patch) 2021-05-31 17:00 PDT, zalan	no flags	Details Formatted Diff Diff
[fast-cq] Patch (66.09 KB, patch) 2021-05-31 19:26 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2021-05-30 07:07:00 PDT

Created attachment 430134 [details] Patch

Antti Koivisto

Comment 2 2021-05-31 07:38:59 PDT

Comment on attachment 430134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430134&action=review > Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:59 > + auto availableVerticalSpace = ((const ConstraintsForTableContent&)constraints).availableVerticalSpaceForContent; What's up with the C cast here?

zalan

Comment 3 2021-05-31 16:54:00 PDT

Created attachment 430216 [details] Patch

zalan

Comment 4 2021-05-31 17:00:59 PDT

Created attachment 430217 [details] Patch

EWS

Comment 5 2021-05-31 19:16:33 PDT

Tools/Scripts/svn-apply failed to apply attachment 430217 [details] to trunk. Please resolve the conflicts and upload a new patch.

zalan

Comment 6 2021-05-31 19:26:24 PDT

Created attachment 430224 [details] [fast-cq] Patch