Bug 226435

Summary: [LFC] Tighten the constraint classes (ConstraintsForInFlowContent/ConstraintsForOutOfFlowContent)
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
[fast-cq] Patch none

Description zalan 2021-05-30 06:57:58 PDT
ssia
Comment 1 zalan 2021-05-30 07:07:00 PDT
Created attachment 430134 [details]
Patch
Comment 2 Antti Koivisto 2021-05-31 07:38:59 PDT
Comment on attachment 430134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430134&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:59
> +    auto availableVerticalSpace = ((const ConstraintsForTableContent&)constraints).availableVerticalSpaceForContent;

What's up with the C cast here?
Comment 3 zalan 2021-05-31 16:54:00 PDT
Created attachment 430216 [details]
Patch
Comment 4 zalan 2021-05-31 17:00:59 PDT
Created attachment 430217 [details]
Patch
Comment 5 EWS 2021-05-31 19:16:33 PDT
Tools/Scripts/svn-apply failed to apply attachment 430217 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 zalan 2021-05-31 19:26:24 PDT
Created attachment 430224 [details]
[fast-cq] Patch
Comment 7 EWS 2021-05-31 19:41:08 PDT
Committed r278292 (238329@main): <https://commits.webkit.org/238329@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430224 [details].
Comment 8 Radar WebKit Bug Importer 2021-05-31 19:42:16 PDT
<rdar://problem/78697838>