| Summary: | Remove WTF::Optional synonym for std::optional, using that class template directly instead | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, alecflett, allan.jensen, apinheiro, bburg, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dbarton, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jbedard, jcraig, jdiggs, jer.noble, jfernandez, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, mcatanzaro, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, rego, ryanhaddad, saam, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, svillar, tommyw, tonikitoo, toyoshim, tzagallo, vjaquez, webkit-bug-importer, youennf, yutak | ||||||||
| Priority: | P3 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 226437 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Darin Adler
2021-05-29 22:36:56 PDT
Created attachment 430130 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Created attachment 430131 [details]
Patch
Comment on attachment 430131 [details]
Patch
R=me once the bots are happy.
Created attachment 430132 [details]
Patch
Committed r278253 (238290@main): <https://commits.webkit.org/238290@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430132 [details]. Seems to have broken the Windows build: https://build.webkit.org/#/builders/67/builds/3216/steps/8/logs/errors The issue is not super obvious to me. (In reply to Chris Dumez from comment #8) > Seems to have broken the Windows build: > https://build.webkit.org/#/builders/67/builds/3216/steps/8/logs/errors > > The issue is not super obvious to me. The include is there so I am wondering if there is a `#define optional` somewhere that is polluting us? (In reply to Chris Dumez from comment #9) > (In reply to Chris Dumez from comment #8) > > Seems to have broken the Windows build: > > https://build.webkit.org/#/builders/67/builds/3216/steps/8/logs/errors > > > > The issue is not super obvious to me. > > The include is there so I am wondering if there is a `#define optional` > somewhere that is polluting us? Or maybe that bot just needs a clean build. Some of the build output still refers to "Optional": 'Inspector::Protocol::Helpers::Optional': definition of dllimport data not allowed Maybe Windows uses a different "erb" file? The EWS Windows build didn’t fail, though! (In reply to Darin Adler from comment #11) > Maybe Windows uses a different "erb" file? The EWS Windows build didn’t > fail, though! And the boy recovered on its own on the next build. It was an incremental build issue I believe. Follow-up build fix in <https://commits.webkit.org/r278319>. (In reply to Chris Dumez from comment #13) > Follow-up build fix in <https://commits.webkit.org/r278319>. And <https://commits.webkit.org/r278320> Very nice! Will the style checker tell me if I use the old thing? A webkit-dev email is probably justified too. We can add it to the style checker, but also it won’t compile. Not compiling seems sufficient. But a webkit-dev heads-up would be welcome. (In reply to Simon Fraser (smfr) from comment #18) > Not compiling seems sufficient. But a webkit-dev heads-up would be welcome. https://lists.webkit.org/pipermail/webkit-dev/2021-June/031875.html |