Bug 226428

Summary: Stop using UncheckedLock in JSC::ConcurrentJSLock
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: JavaScriptCoreAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226432    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2021-05-29 17:37:37 PDT 
Stop using UncheckedLock in JSC::ConcurrentJSLock as it is being phased out in favor of Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-29 17:39:01 PDT 
Created attachment 430118 [details]
Patch
Comment 2 EWS 2021-05-29 22:36:05 PDT 
Committed r278249 (238286@main): <https://commits.webkit.org/238286@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430118 [details].
Comment 3 Radar WebKit Bug Importer 2021-05-29 22:37:21 PDT 
<rdar://problem/78656527>
Comment 4 Darin Adler 2021-05-29 23:08:55 PDT 
Comment on attachment 430118 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430118&action=review

> Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> +    Optional<ConcurrentJSLockerImpl> m_locker;

I should have remembered to ask you to use std::optional<> here. Optional<> is a deprecated synonym.
Comment 5 Chris Dumez 2021-05-29 23:11:36 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 430118 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430118&action=review
> 
> > Source/JavaScriptCore/runtime/ConcurrentJSLock.h:68
> > +    Optional<ConcurrentJSLockerImpl> m_locker;
> 
> I should have remembered to ask you to use std::optional<> here. Optional<>
> is a deprecated synonym.

Old habits die hard, sorry :/