Summary: | Stop using UncheckedLock in JSC::VMInspector | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | JavaScriptCore | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cmarcelo, darin, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 226432 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2021-05-29 16:31:03 PDT
Created attachment 430115 [details]
Patch
Created attachment 430117 [details]
Patch
Comment on attachment 430117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430117&action=review r=me > Source/WTF/wtf/Lock.cpp:35 > +#include <unistd.h> Is the #include in VMInspector.cpp still needed? If not, can you remove it? Created attachment 430129 [details]
Patch
(In reply to Mark Lam from comment #3) > Comment on attachment 430117 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430117&action=review > > r=me > > > Source/WTF/wtf/Lock.cpp:35 > > +#include <unistd.h> > > Is the #include in VMInspector.cpp still needed? If not, can you remove it? Done. Committed r278251 (238288@main): <https://commits.webkit.org/238288@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430129 [details]. |