Bug 226427

Summary: Stop using UncheckedLock in JSC::VMInspector
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: JavaScriptCoreAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, darin, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226432    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Chris Dumez 2021-05-29 16:31:03 PDT
Stop using UncheckedLock in JSC::VMInspector, as it is being phased out in favor of Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-29 16:51:13 PDT
Created attachment 430115 [details]
Patch
Comment 2 Chris Dumez 2021-05-29 17:06:09 PDT
Created attachment 430117 [details]
Patch
Comment 3 Mark Lam 2021-05-29 21:49:55 PDT
Comment on attachment 430117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430117&action=review

r=me

> Source/WTF/wtf/Lock.cpp:35
> +#include <unistd.h>

Is the #include in VMInspector.cpp still needed?  If not, can you remove it?
Comment 4 Chris Dumez 2021-05-29 22:24:35 PDT
Created attachment 430129 [details]
Patch
Comment 5 Chris Dumez 2021-05-29 22:24:55 PDT
(In reply to Mark Lam from comment #3)
> Comment on attachment 430117 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=430117&action=review
> 
> r=me
> 
> > Source/WTF/wtf/Lock.cpp:35
> > +#include <unistd.h>
> 
> Is the #include in VMInspector.cpp still needed?  If not, can you remove it?

Done.
Comment 6 EWS 2021-05-29 23:52:04 PDT
Committed r278251 (238288@main): <https://commits.webkit.org/238288@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430129 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-29 23:53:20 PDT
<rdar://problem/78657229>