Bug 226402

Summary: [WebXR] Send recommendedResolution using DeviceProxy
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebXRAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, ews-feeder: commit-queue-
EWS test none

Dean Jackson
Reported 2021-05-28 15:46:04 PDT
The DeviceProxy will provide the recommended resolution, which is then used by WebXROpaqueFramebuffer to create backing store of the correct dimensions.
Attachments
Patch (4.31 KB, patch)
2021-05-28 16:17 PDT, Dean Jackson 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
EWS test (4.34 KB, patch)
2021-05-30 12:35 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-28 15:46:25 PDT
<rdar://problem/78635475>
Dean Jackson
Comment 2 2021-05-28 16:17:07 PDT
Created attachment 430068 [details] Patch
Tim Horton
Comment 3 2021-05-28 16:24:32 PDT
Comment on attachment 430068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430068&action=review > Source/WebKit/Shared/Cocoa/XRDeviceInfo.h:45 > + WebCore::IntSize recommendedResolution { 1, 1 }; Seems fine, though I slightly question the default of 1x1 instead of just the default IntSize (0x0). Neither one is particularly useful?
Dean Jackson
Comment 4 2021-05-30 12:35:42 PDT
Created attachment 430144 [details] EWS test
Dean Jackson
Comment 5 2021-05-30 14:37:21 PDT
Committed r278258 (238295@main): <https://commits.webkit.org/238295@main>
Note You need to log in before you can comment on or make changes to this bug.