Bug 226402

Summary: [WebXR] Send recommendedResolution using DeviceProxy
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebXRAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, ews-feeder: commit-queue-
EWS test none

Description Dean Jackson 2021-05-28 15:46:04 PDT 
The DeviceProxy will provide the recommended resolution, which is then used by WebXROpaqueFramebuffer to create backing store of the correct dimensions.
Comment 1 Radar WebKit Bug Importer 2021-05-28 15:46:25 PDT 
<rdar://problem/78635475>
Comment 2 Dean Jackson 2021-05-28 16:17:07 PDT 
Created attachment 430068 [details]
Patch
Comment 3 Tim Horton 2021-05-28 16:24:32 PDT 
Comment on attachment 430068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430068&action=review

> Source/WebKit/Shared/Cocoa/XRDeviceInfo.h:45
> +    WebCore::IntSize recommendedResolution { 1, 1 };

Seems fine, though I slightly question the default of 1x1 instead of just the default IntSize (0x0). Neither one is particularly useful?
Comment 4 Dean Jackson 2021-05-30 12:35:42 PDT 
Created attachment 430144 [details]
EWS test
Comment 5 Dean Jackson 2021-05-30 14:37:21 PDT 
Committed r278258 (238295@main): <https://commits.webkit.org/238295@main>