Bug 226402 - [WebXR] Send recommendedResolution using DeviceProxy
Summary: [WebXR] Send recommendedResolution using DeviceProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-28 15:46 PDT by Dean Jackson
Modified: 2021-05-30 14:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2021-05-28 16:17 PDT, Dean Jackson 		thorton: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS test (4.34 KB, patch)
2021-05-30 12:35 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2021-05-28 15:46:04 PDT 
The DeviceProxy will provide the recommended resolution, which is then used by WebXROpaqueFramebuffer to create backing store of the correct dimensions.
Comment 1 Radar WebKit Bug Importer 2021-05-28 15:46:25 PDT 
<rdar://problem/78635475>
Comment 2 Dean Jackson 2021-05-28 16:17:07 PDT 
Created attachment 430068 [details]
Patch
Comment 3 Tim Horton 2021-05-28 16:24:32 PDT 
Comment on attachment 430068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430068&action=review

> Source/WebKit/Shared/Cocoa/XRDeviceInfo.h:45
> +    WebCore::IntSize recommendedResolution { 1, 1 };

Seems fine, though I slightly question the default of 1x1 instead of just the default IntSize (0x0). Neither one is particularly useful?
Comment 4 Dean Jackson 2021-05-30 12:35:42 PDT 
Created attachment 430144 [details]
EWS test
Comment 5 Dean Jackson 2021-05-30 14:37:21 PDT 
Committed r278258 (238295@main): <https://commits.webkit.org/238295@main>