Bug 226396

Summary: Stop using UncheckedLock in WTF::MetaAllocator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, ddkilzer, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Chris Dumez
Reported 2021-05-28 14:36:46 PDT
Stop using UncheckedLock in WTF::MetaAllocator, as it is being phased out in favor on Lock, which supports Clang thread safety analysis.
Attachments
Patch (10.39 KB, patch)
2021-05-28 14:37 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2021-05-28 14:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2021-05-28 17:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-28 14:37:55 PDT
Created attachment 430053 [details] Patch
Chris Dumez
Comment 2 2021-05-28 14:52:29 PDT
Created attachment 430060 [details] Patch
Darin Adler
Comment 3 2021-05-28 16:28:37 PDT
Comment on attachment 430060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430060&action=review > Source/JavaScriptCore/tools/VMInspector.cpp:131 > + WTF::Locker executableAllocatorLocker { lock }; The usual "using WTF" trick doesn’t work here?
Chris Dumez
Comment 4 2021-05-28 16:30:11 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 430060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430060&action=review > > > Source/JavaScriptCore/tools/VMInspector.cpp:131 > > + WTF::Locker executableAllocatorLocker { lock }; > > The usual "using WTF" trick doesn’t work here? The issue is that VMInspector has a using `Locker = Locker<UncheckedLock>`. I will look into removing it.
Chris Dumez
Comment 5 2021-05-28 17:02:36 PDT
Created attachment 430075 [details] Patch
EWS
Comment 6 2021-05-28 18:06:02 PDT
Committed r278232 (238269@main): <https://commits.webkit.org/238269@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430075 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-28 18:07:24 PDT
<rdar://problem/78639206>
Note You need to log in before you can comment on or make changes to this bug.