Summary: | Stop using UncheckedLock in WTF::MetaAllocator | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Web Template Framework | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, benjamin, cmarcelo, darin, ddkilzer, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2021-05-28 14:36:46 PDT
Created attachment 430053 [details]
Patch
Created attachment 430060 [details]
Patch
Comment on attachment 430060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430060&action=review > Source/JavaScriptCore/tools/VMInspector.cpp:131 > + WTF::Locker executableAllocatorLocker { lock }; The usual "using WTF" trick doesn’t work here? (In reply to Darin Adler from comment #3) > Comment on attachment 430060 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430060&action=review > > > Source/JavaScriptCore/tools/VMInspector.cpp:131 > > + WTF::Locker executableAllocatorLocker { lock }; > > The usual "using WTF" trick doesn’t work here? The issue is that VMInspector has a using `Locker = Locker<UncheckedLock>`. I will look into removing it. Created attachment 430075 [details]
Patch
Committed r278232 (238269@main): <https://commits.webkit.org/238269@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430075 [details]. |