Bug 22638

Summary: Add POST method support to WML <go> element
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 22949    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch
none
Layout test results
none
Updated patch
staikos: review+
Updated layout test results
staikos: review+
WebKitTools changes staikos: review+

Nikolas Zimmermann
Reported 2008-12-03 16:19:24 PST
Add POST method support to WML <go> element.
Attachments
Initial patch (10.21 KB, patch)
2008-12-20 17:26 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Layout test results (23.09 KB, patch)
2008-12-20 17:26 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (10.42 KB, patch)
2008-12-21 17:50 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
Updated layout test results (22.87 KB, patch)
2008-12-21 17:51 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
WebKitTools changes (1.62 KB, patch)
2008-12-21 18:02 PST, Nikolas Zimmermann 		staikos: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2008-12-20 17:26:19 PST
Created attachment 26174 [details] Initial patch
Nikolas Zimmermann
Comment 2 2008-12-20 17:26:41 PST
Created attachment 26175 [details] Layout test results
Nikolas Zimmermann
Comment 3 2008-12-20 18:49:11 PST
Comment on attachment 26174 [details] Initial patch Clearing review flag for now. As suggested by Holger, a better approach would be to create a FormDataBuilder class, which encapsulates the Vector<char> instead of having to pass it to several functions, as it is in this patch. Uploading a revised version soon - see bug 22949.
Nikolas Zimmermann
Comment 4 2008-12-21 17:50:58 PST
Created attachment 26193 [details] Updated patch
Nikolas Zimmermann
Comment 5 2008-12-21 17:51:26 PST
Created attachment 26194 [details] Updated layout test results
Nikolas Zimmermann
Comment 6 2008-12-21 17:52:33 PST
Adapted to changes in bug 22949 - helper class is now called 'FormDataBuilder', not 'FormElementData'.
Nikolas Zimmermann
Comment 7 2008-12-21 18:02:10 PST
Created attachment 26195 [details] WebKitTools changes
Nikolas Zimmermann
Comment 8 2008-12-21 18:05:56 PST
Landed in r39431.
Note You need to log in before you can comment on or make changes to this bug.