Bug 22638

Summary: Add POST method support to WML <go> element
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 22949    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch
none
Layout test results
none
Updated patch
staikos: review+
Updated layout test results
staikos: review+
WebKitTools changes staikos: review+

Description Nikolas Zimmermann 2008-12-03 16:19:24 PST
Add POST method support to WML <go> element.
Comment 1 Nikolas Zimmermann 2008-12-20 17:26:19 PST
Created attachment 26174 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-12-20 17:26:41 PST
Created attachment 26175 [details]
Layout test results
Comment 3 Nikolas Zimmermann 2008-12-20 18:49:11 PST
Comment on attachment 26174 [details]
Initial patch

Clearing review flag for now. As suggested by Holger, a better approach would be to create a FormDataBuilder class, which encapsulates the Vector<char> instead of having to pass it to several functions, as it is in this patch. Uploading a revised version soon - see bug 22949.
Comment 4 Nikolas Zimmermann 2008-12-21 17:50:58 PST
Created attachment 26193 [details]
Updated patch
Comment 5 Nikolas Zimmermann 2008-12-21 17:51:26 PST
Created attachment 26194 [details]
Updated layout test results
Comment 6 Nikolas Zimmermann 2008-12-21 17:52:33 PST
Adapted to changes in bug 22949 - helper class is now called 'FormDataBuilder', not 'FormElementData'.
Comment 7 Nikolas Zimmermann 2008-12-21 18:02:10 PST
Created attachment 26195 [details]
WebKitTools changes
Comment 8 Nikolas Zimmermann 2008-12-21 18:05:56 PST
Landed in r39431.