Bug 226366

Summary: Add 'mix' override with bool-vectors to MSL translator
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: ANGLEAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kyle Piddington
Reported 2021-05-27 21:08:30 PDT
The GLSL function 'mix' includes several overrides that take a bool vector. However, MSL does not natively support this. Add in functionality and a test to support mix with bool
Attachments
Patch (7.65 KB, patch)
2021-05-27 21:11 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (9.67 KB, patch)
2021-05-28 10:49 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-05-27 21:11:18 PDT
Created attachment 429981 [details] Patch
EWS Watchlist
Comment 2 2021-05-27 21:12:15 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kimmo Kinnunen
Comment 3 2021-05-27 22:46:37 PDT
Comment on attachment 429981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429981&action=review otherwise looks good as far as I can understand > Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:262 > + const TType *argType2 = nullptr) two spaces here :) > LayoutTests/ChangeLog:9 > + * fast/canvas/webgl/shader-mix-with-bool-expected.txt: Added. you didn't add the test case :)
Kyle Piddington
Comment 4 2021-05-28 10:49:15 PDT
Created attachment 430028 [details] Patch
EWS
Comment 5 2021-06-02 10:01:56 PDT
Committed r278362 (238392@main): <https://commits.webkit.org/238392@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430028 [details].
Radar WebKit Bug Importer
Comment 6 2021-06-02 10:02:20 PDT
<rdar://problem/78769564>
Note You need to log in before you can comment on or make changes to this bug.