Bug 226356

Summary: [GPU Process] Add debug logging around some shared display list codepaths
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For EWS none

Wenson Hsieh
Reported 2021-05-27 14:20:27 PDT
Add log messages to assist with basic triage and debugging.
Attachments
Patch (11.25 KB, patch)
2021-05-27 14:36 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For EWS (11.23 KB, patch)
2021-05-27 16:56 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-05-27 14:36:59 PDT
Created attachment 429930 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-05-27 15:11:49 PDT
Comment on attachment 429930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review > Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96 > + LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64()); LOG_WITH_STREAM avoids the need for PRIu64 shenanigans.
Wenson Hsieh
Comment 3 2021-05-27 15:25:20 PDT
Comment on attachment 429930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review >> Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96 >> + LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64()); > > LOG_WITH_STREAM avoids the need for PRIu64 shenanigans. Sounds good! Will change these to use `LOG_WITH_STREAM`.
Wenson Hsieh
Comment 4 2021-05-27 16:56:12 PDT
Created attachment 429957 [details] For EWS
EWS
Comment 5 2021-05-27 22:26:31 PDT
Committed r278191 (238234@main): <https://commits.webkit.org/238234@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429957 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-27 22:27:17 PDT
<rdar://problem/78604419>
Note You need to log in before you can comment on or make changes to this bug.