| Summary: | [GPU Process] Add debug logging around some shared display list codepaths | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2021-05-27 14:20:27 PDT
Created attachment 429930 [details]
Patch
Comment on attachment 429930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review > Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96 > + LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64()); LOG_WITH_STREAM avoids the need for PRIu64 shenanigans. Comment on attachment 429930 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429930&action=review >> Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:96 >> + LOG(SharedDisplayLists, "Acknowledging Flush{%" PRIu64 "} in Image(%" PRIu64 ")", identifier.toUInt64(), m_renderingResourceIdentifier.toUInt64()); > > LOG_WITH_STREAM avoids the need for PRIu64 shenanigans. Sounds good! Will change these to use `LOG_WITH_STREAM`. Created attachment 429957 [details]
For EWS
Committed r278191 (238234@main): <https://commits.webkit.org/238234@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429957 [details]. |