Bug 226309

Summary: [Win] Remove unused GraphicsContext::hdc()
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Fujii Hironori
Reported 2021-05-26 17:55:38 PDT
[Win] Remove unused GraphicsContext::hdc()
Attachments
Patch (2.28 KB, patch)
2021-05-26 17:56 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2021-05-31 13:52 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.33 KB, patch)
2021-06-01 13:27 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-05-26 17:56:59 PDT
Created attachment 429820 [details] Patch
Fujii Hironori
Comment 2 2021-05-26 19:44:08 PDT
Comment on attachment 429820 [details] Patch AppleWin EWS failed. It is still used. C:\cygwin\home\buildbot\worker\Windows-EWS\build\Source\WebKitLegacy\win\Plugins\PluginViewWin.cpp(557,8): error C2039: 'hdc': is not a member of 'WebCore::GraphicsContext' [C:\cygwin\home\buildbot\worker\Windows-EWS\build\WebKitBuild\Release\Source\WebKitLegacy\WebKitLegacy.vcxproj]
Fujii Hironori
Comment 3 2021-05-30 21:16:09 PDT
(In reply to Fujii Hironori from comment #2) > AppleWin EWS failed. It is still used. r278265 removed the code.
Fujii Hironori
Comment 4 2021-05-31 13:52:53 PDT
Created attachment 430212 [details] Patch
Fujii Hironori
Comment 5 2021-06-01 13:27:42 PDT
Created attachment 430286 [details] Patch for landing
EWS
Comment 6 2021-06-01 14:04:44 PDT
Committed r278328 (238361@main): <https://commits.webkit.org/238361@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430286 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-01 14:05:20 PDT
<rdar://problem/78731782>
Note You need to log in before you can comment on or make changes to this bug.