Summary: | [iOS] Preprocess the WebContent sandbox | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bfulgham, ggaren, thorton, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-05-26 15:37:17 PDT
Created attachment 429805 [details]
Patch
Created attachment 429806 [details]
Patch
Created attachment 429807 [details]
Patch
Created attachment 429811 [details]
Patch
Comment on attachment 429811 [details]
Patch
r=me
Comment on attachment 429811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429811&action=review It looks like this just adds the preprocessing step, but doesn't take any action at present -- is that right? > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=226301 Can you include the radar here? > Source/WebKit/ChangeLog:8 > + Run the WebContent sandbox through the preprocessor on iOS. It doesn't appear that we have any conditional compilation here yet, right? It seems like this patch is just about doing the preprocessing (which does nothing in this patch). Created attachment 430092 [details]
Patch
Created attachment 430093 [details]
Patch
(In reply to Geoffrey Garen from comment #5) > Comment on attachment 429811 [details] > Patch > > r=me Thanks for reviewing! (In reply to Brent Fulgham from comment #6) > Comment on attachment 429811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429811&action=review > > It looks like this just adds the preprocessing step, but doesn't take any > action at present -- is that right? > > > Source/WebKit/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=226301 > > Can you include the radar here? > Done! > > Source/WebKit/ChangeLog:8 > > + Run the WebContent sandbox through the preprocessor on iOS. > > It doesn't appear that we have any conditional compilation here yet, right? > It seems like this patch is just about doing the preprocessing (which does > nothing in this patch). Yes, that is correct. Thanks for reviewing! Committed r278308 (238345@main): <https://commits.webkit.org/238345@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430093 [details]. |