Bug 226301

Summary: [iOS] Preprocess the WebContent sandbox
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ggaren, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ggaren: review+, ews-feeder: commit-queue-
Patch
none
Patch none

Per Arne Vollan
Reported 2021-05-26 15:37:17 PDT
Run the WebContent sandbox through the preprocessor on iOS.
Attachments
Patch (135.64 KB, patch)
2021-05-26 15:42 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (135.04 KB, patch)
2021-05-26 15:44 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (136.44 KB, patch)
2021-05-26 15:47 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (136.44 KB, patch)
2021-05-26 16:17 PDT, Per Arne Vollan 		ggaren: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (138.78 KB, patch)
2021-05-29 07:27 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (138.60 KB, patch)
2021-05-29 07:35 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-05-26 15:42:01 PDT
Created attachment 429805 [details] Patch
Per Arne Vollan
Comment 2 2021-05-26 15:44:34 PDT
Created attachment 429806 [details] Patch
Per Arne Vollan
Comment 3 2021-05-26 15:47:56 PDT
Created attachment 429807 [details] Patch
Per Arne Vollan
Comment 4 2021-05-26 16:17:10 PDT
Created attachment 429811 [details] Patch
Geoffrey Garen
Comment 5 2021-05-27 09:42:21 PDT
Comment on attachment 429811 [details] Patch r=me
Brent Fulgham
Comment 6 2021-05-27 09:56:00 PDT
Comment on attachment 429811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429811&action=review It looks like this just adds the preprocessing step, but doesn't take any action at present -- is that right? > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=226301 Can you include the radar here? > Source/WebKit/ChangeLog:8 > + Run the WebContent sandbox through the preprocessor on iOS. It doesn't appear that we have any conditional compilation here yet, right? It seems like this patch is just about doing the preprocessing (which does nothing in this patch).
Radar WebKit Bug Importer
Comment 7 2021-05-27 10:26:55 PDT
<rdar://problem/78575178>
Per Arne Vollan
Comment 8 2021-05-29 07:27:23 PDT
Created attachment 430092 [details] Patch
Per Arne Vollan
Comment 9 2021-05-29 07:35:30 PDT
Created attachment 430093 [details] Patch
Per Arne Vollan
Comment 10 2021-05-29 07:39:24 PDT
(In reply to Geoffrey Garen from comment #5) > Comment on attachment 429811 [details] > Patch > > r=me Thanks for reviewing!
Per Arne Vollan
Comment 11 2021-05-29 07:40:02 PDT
(In reply to Brent Fulgham from comment #6) > Comment on attachment 429811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429811&action=review > > It looks like this just adds the preprocessing step, but doesn't take any > action at present -- is that right? > > > Source/WebKit/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=226301 > > Can you include the radar here? > Done! > > Source/WebKit/ChangeLog:8 > > + Run the WebContent sandbox through the preprocessor on iOS. > > It doesn't appear that we have any conditional compilation here yet, right? > It seems like this patch is just about doing the preprocessing (which does > nothing in this patch). Yes, that is correct. Thanks for reviewing!
EWS
Comment 12 2021-06-01 08:19:45 PDT
Committed r278308 (238345@main): <https://commits.webkit.org/238345@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430093 [details].
Note You need to log in before you can comment on or make changes to this bug.