Bug 226300

Summary: Cleanup temporary directory after TestWTF's FileSystemTests
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: Tools / TestsAssignee: Stephan Szabo <stephan.szabo>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2021-05-26 15:37:03 PDT
Some tests like FileSystemTest.moveFile, the m_tempEmptyFolderPath is used as a destination and may not get cleaned if the file still exists at the end of the test since it's no longer empty, so move to using deleteNonEmptyDirectory during cleanup.
Attachments
Patch (1.27 KB, patch)
2021-05-26 15:39 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2021-05-26 15:39:45 PDT
Created attachment 429804 [details] Patch
Chris Dumez
Comment 2 2021-05-26 15:47:14 PDT
Comment on attachment 429804 [details] Patch r=me
EWS
Comment 3 2021-05-26 17:35:47 PDT
Committed r278138 (238183@main): <https://commits.webkit.org/238183@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429804 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-26 17:36:19 PDT
<rdar://problem/78542451>
Note You need to log in before you can comment on or make changes to this bug.