Summary: | [Metal ANGLE] transformFeedback samples on webglsamples.org do not render correctly | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kyle Piddington <kpiddington> | ||||||||
Component: | New Bugs | Assignee: | Kyle Piddington <kpiddington> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, ews-watchlist, graouts, johncunningham, kondapallykalyan, sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Kyle Piddington
2021-05-26 12:31:15 PDT
Created attachment 429782 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Pasting from an internal discussion (John Cunningham): lgtm though I’d rather see memoryBarrier on macos if not difficult to add on AGX macos it just ends and starts a new render pass anyways, but I think it is more efficient on nonagx Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review > Source/ThirdParty/ANGLE/ChangeLog:11 > + for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader. typo transsform Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review >> Source/ThirdParty/ANGLE/ChangeLog:11 >> + for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader. > > typo transsform And seperated (found it at http://webglsamples.org/WebGL2Samples/#transform_feedback_separated_2) Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review Is the prepareForTransformFeedbackPassTwo not needed in drawTriFanArraysLegacy and drawLineLoopArrays > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:1405 > +void ContextMtl::onEndTransformFeedback(const gl::Context *context) context isn't used in this function > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TransformFeedbackMtl.mm:96 > + contextMtl->onEndTransformFeedback(context); not needed if context isn't used in onEndTransformFeedback Created attachment 429936 [details]
Patch
Created attachment 430054 [details]
Patch
Comment on attachment 430054 [details]
Patch
LGTM
Committed r278335 (238368@main): <https://commits.webkit.org/238368@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430054 [details]. |