Bug 226280

Summary: Next step toward using std::optional directly instead of through WTF::Optional typedef
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, apinheiro, bburg, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dbarton, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jcraig, jdiggs, jer.noble, jfernandez, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, rego, ryuan.choi, saam, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, svillar, tommyw, tonikitoo, toyoshim, tzagallo, vjaquez, webkit-bug-importer, yutak, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch sam: review+

Darin Adler
Reported 2021-05-26 11:00:17 PDT
Next step toward using std::optional directly instead of through WTF::Optional typedef
Attachments
Patch (2.41 MB, patch)
2021-05-26 21:54 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (2.41 MB, patch)
2021-05-26 22:26 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (2.44 MB, patch)
2021-05-27 09:30 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (2.48 MB, patch)
2021-05-27 14:54 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-05-26 21:54:08 PDT
Created attachment 429844 [details] Patch
Darin Adler
Comment 2 2021-05-26 22:26:00 PDT
Created attachment 429845 [details] Patch
EWS Watchlist
Comment 3 2021-05-26 22:27:44 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Chris Dumez
Comment 4 2021-05-26 23:11:18 PDT
Comment on attachment 429845 [details] Patch I see you couldn’t resist and did some refactoring in this already very large patch :) r=me once the bots are happy.
Darin Adler
Comment 5 2021-05-27 09:30:02 PDT
Created attachment 429887 [details] Patch
Darin Adler
Comment 6 2021-05-27 14:54:46 PDT
Created attachment 429932 [details] Patch
Darin Adler
Comment 7 2021-05-27 18:26:56 PDT
Committed r278185 (238228@main): <https://commits.webkit.org/238228@main>
Radar WebKit Bug Importer
Comment 8 2021-05-27 18:27:24 PDT
<rdar://problem/78598141>
Note You need to log in before you can comment on or make changes to this bug.