| Summary: | Next step toward using std::optional directly instead of through WTF::Optional typedef | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aboxhall, alecflett, apinheiro, bburg, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dbarton, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, galpeter, glenn, graouts, gustavo, gyuyoung.kim, hi, hta, jamesr, japhet, jcraig, jdiggs, jer.noble, jfernandez, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pdr, philipj, pnormand, rego, ryuan.choi, saam, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, svillar, tommyw, tonikitoo, toyoshim, tzagallo, vjaquez, webkit-bug-importer, yutak, zeno | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Darin Adler
2021-05-26 11:00:17 PDT
Created attachment 429844 [details]
Patch
Created attachment 429845 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) Comment on attachment 429845 [details]
Patch
I see you couldn’t resist and did some refactoring in this already very large patch :) r=me once the bots are happy.
Created attachment 429887 [details]
Patch
Created attachment 429932 [details]
Patch
Committed r278185 (238228@main): <https://commits.webkit.org/238228@main> |