Bug 226279

Summary: Convert small JIT pool tests into executable fuzzing
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228036
Bug Depends on: 226606, 228037    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Keith Miller 2021-05-26 10:10:52 PDT 
Convert small JIT pool tests into executable fuzzing
Comment 1 Keith Miller 2021-05-26 10:17:15 PDT 
Created attachment 429768 [details]
Patch
Comment 2 Michael Saboff 2021-05-26 10:19:32 PDT 
Comment on attachment 429768 [details]
Patch

r=me
Comment 3 Keith Miller 2021-05-26 10:20:07 PDT 
Created attachment 429770 [details]
Patch
Comment 4 Keith Miller 2021-05-26 10:26:38 PDT 
Created attachment 429773 [details]
Patch for landing
Comment 5 EWS 2021-05-26 10:27:17 PDT 
Tools/Scripts/svn-apply failed to apply attachment 429773 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Keith Miller 2021-06-02 08:50:42 PDT 
Created attachment 430364 [details]
Patch for landing
Comment 7 EWS 2021-06-02 09:26:07 PDT 
Committed r278356 (238388@main): <https://commits.webkit.org/238388@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430364 [details].
Comment 8 Radar WebKit Bug Importer 2021-06-02 09:27:22 PDT 
<rdar://problem/78767508>
Comment 9 WebKit Commit Bot 2021-06-03 15:41:51 PDT 
Re-opened since this is blocked by bug 226606
Comment 10 Keith Miller 2021-07-14 12:08:59 PDT 
Created attachment 433516 [details]
Patch for landing
Comment 11 EWS 2021-07-14 12:58:24 PDT 
Committed r279916 (239665@main): <https://commits.webkit.org/239665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433516 [details].
Comment 12 Saam Barati 2021-07-14 16:24:11 PDT 
Comment on attachment 433516 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=433516&action=review

We also are using the random executable allocation fuzzer for all our tests now: https://trac.webkit.org/changeset/279126/webkit

> Source/JavaScriptCore/jit/ExecutableAllocationFuzz.cpp:44
> +    static WeakRandom random(Options::seedOfVMRandomForFuzzer() ? Options::seedOfVMRandomForFuzzer() : cryptographicallyRandomNumber());

Why is this defined right here? Maybe we can unify w/ WeakRandom below? Kinda confusing to put this definition here and not use it until way later.

I think this should also be a LazyNeverDestroyed like below?

Maybe also should use a lock like below?
Comment 13 WebKit Commit Bot 2021-07-16 15:16:48 PDT 
Re-opened since this is blocked by bug 228037