Bug 226275

Summary:	#ifdef out transformToColorSpace() in ImageBuffer and subclasses to make it clear it is only needed for non-CG ports
Product:	WebKit	Reporter:	Sam Weinig <sam>
Component:	Platform	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Sam Weinig 2021-05-26 08:54:26 PDT

We currently have no-op implementations of transformToColorSpace() in ImageBuffer and its CG subclasses. I think we should make it clear it is not intended to work for CG by making it impossible to call via #ifdef.

Comment 1 Sam Weinig 2021-05-26 08:56:45 PDT

Really, we should have a better macro for this. Maybe ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE?

Comment 2 Sam Weinig 2021-05-26 09:05:23 PDT

ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE is not great, because it will be really confusing to see:

#if !ENABLE(IMAGE_BUFFER_SUPPORTS_COLOR_SPACE)
    maskerData->maskImage->transformToColorSpace(colorSpace);
#endif

Perhaps the real answer is that we need to replace transformToColorSpace() with something that makes it clear it is not really correct. Like a function that just does a getPixelBuffer -> colorSpace transformation > setPixelBuffer(), though that would obviously be less efficient so not a good idea.

Comment 3 Radar WebKit Bug Importer 2021-06-02 08:55:19 PDT

<rdar://problem/78765976>