Bug 226269

Summary: [LFC] Introduce containingBlockChain iterator
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2021-05-26 07:58:01 PDT 
Iterator for the containing block chain
Comment 1 zalan 2021-05-26 08:04:48 PDT 
Created attachment 429758 [details]
Patch
Comment 2 Antti Koivisto 2021-05-26 08:10:04 PDT 
Comment on attachment 429758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429758&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp:70
> +    for (auto& ancestor : containingBlockChainOf(layoutBox)) {

Not sure if the "Of" adds anything.

> Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:54
> +    LayoutContainingBlockChainIterator begin() { return LayoutContainingBlockChainIterator(m_containingBlock); }
> +    LayoutContainingBlockChainIterator end() { return LayoutContainingBlockChainIterator(); }

could be 

auto begin()
auto end()
Comment 3 zalan 2021-05-26 08:18:42 PDT 
Created attachment 429760 [details]
Patch
Comment 4 zalan 2021-05-26 08:19:37 PDT 
Created attachment 429761 [details]
Patch
Comment 5 EWS 2021-05-26 09:30:30 PDT 
Committed r278086 (238163@main): <https://commits.webkit.org/238163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429761 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-26 09:31:23 PDT 
<rdar://problem/78516872>