Bug 226269

Summary: [LFC] Introduce containingBlockChain iterator
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2021-05-26 07:58:01 PDT
Iterator for the containing block chain
Attachments
Patch (10.91 KB, patch)
2021-05-26 08:04 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.84 KB, patch)
2021-05-26 08:18 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.85 KB, patch)
2021-05-26 08:19 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-05-26 08:04:48 PDT
Created attachment 429758 [details] Patch
Antti Koivisto
Comment 2 2021-05-26 08:10:04 PDT
Comment on attachment 429758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429758&action=review > Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp:70 > + for (auto& ancestor : containingBlockChainOf(layoutBox)) { Not sure if the "Of" adds anything. > Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:54 > + LayoutContainingBlockChainIterator begin() { return LayoutContainingBlockChainIterator(m_containingBlock); } > + LayoutContainingBlockChainIterator end() { return LayoutContainingBlockChainIterator(); } could be auto begin() auto end()
zalan
Comment 3 2021-05-26 08:18:42 PDT
Created attachment 429760 [details] Patch
zalan
Comment 4 2021-05-26 08:19:37 PDT
Created attachment 429761 [details] Patch
EWS
Comment 5 2021-05-26 09:30:30 PDT
Committed r278086 (238163@main): <https://commits.webkit.org/238163@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429761 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-26 09:31:23 PDT
<rdar://problem/78516872>
Note You need to log in before you can comment on or make changes to this bug.