Bug 226261

Summary: ANGLE Metal translator should always collect variables
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, johncunningham, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-05-26 02:26:00 PDT
ANGLE Metal translator should always collect variables RemoveInactiveInterfaceVariables helper function needs the variables to be collected. Normal operation invokes this as a side-effect of passing SH_VARIABLES compile option. However, some tests might not pass the compile option, but Metal translator still removes the inactive interface variables. Thus we need to always collect the variables.
Attachments
Patch (1.90 KB, patch)
2021-05-26 02:32 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-05-26 02:32:20 PDT
Created attachment 429741 [details] Patch
EWS Watchlist
Comment 2 2021-05-26 02:33:11 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
John Cunningham
Comment 3 2021-05-26 18:30:43 PDT
Comment on attachment 429741 [details] Patch LGTM
EWS
Comment 4 2021-05-28 00:15:50 PDT
Committed r278192 (238235@main): <https://commits.webkit.org/238235@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429741 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-28 00:16:20 PDT
<rdar://problem/78607455>
Note You need to log in before you can comment on or make changes to this bug.