Bug 226252

Summary: Use `NSLocale` SPI for comparing language identifiers instead of string comparison
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hi, jer.noble, mmaxfield, philipj, sergio, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226038
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Devin Rousso 2021-05-25 17:22:08 PDT 
.
Comment 1 Devin Rousso 2021-05-25 17:27:30 PDT 
Created attachment 429715 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-05-25 18:18:03 PDT 
Comment on attachment 429715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429715&action=review

> Source/WTF/ChangeLog:4
> +        Use `NSLocale` SPI for comparing language identifiers instead of string comparison
> +        https://bugs.webkit.org/show_bug.cgi?id=226252

A "why" comment would be very useful here.
Comment 3 Devin Rousso 2021-05-26 20:17:13 PDT 
Created attachment 429834 [details]
Patch
Comment 4 Devin Rousso 2021-05-26 20:40:52 PDT 
Created attachment 429837 [details]
Patch
Comment 5 EWS 2021-05-27 10:54:22 PDT 
Committed r278168 (238212@main): <https://commits.webkit.org/238212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429837 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-27 10:55:19 PDT 
<rdar://problem/78576565>