Bug 226250

Summary: Stop using UncheckedLock in MediaElementAudioSourceNode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, calvaris, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Chris Dumez
Reported 2021-05-25 16:37:51 PDT
Stop using UncheckedLock in MediaElementAudioSourceNode as it is being phased out in favor of Lock, which supports clang thread safety analysis.
Attachments
Patch (3.88 KB, patch)
2021-05-25 17:24 PDT, Chris Dumez 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-25 17:24:43 PDT
Created attachment 429714 [details] Patch
Darin Adler
Comment 2 2021-05-25 20:39:00 PDT
Comment on attachment 429714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429714&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6635 > + Optional<Locker<Lock>> audioSourceNodeLocker; In new code you should write std::optional, not Optional.
Chris Dumez
Comment 3 2021-05-25 22:00:55 PDT
Committed r278077 (238156@main): <https://commits.webkit.org/238156@main>
Radar WebKit Bug Importer
Comment 4 2021-05-25 22:01:21 PDT
<rdar://problem/78494211>
Note You need to log in before you can comment on or make changes to this bug.