Bug 226250

Summary:

Stop using UncheckedLock in MediaElementAudioSourceNode

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Media

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, calvaris, changseok, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Chris Dumez 2021-05-25 16:37:51 PDT

Stop using UncheckedLock in MediaElementAudioSourceNode as it is being phased out in favor of Lock, which supports clang thread safety analysis.

Comment 1 Chris Dumez 2021-05-25 17:24:43 PDT

Created attachment 429714 [details]
Patch

Comment 2 Darin Adler 2021-05-25 20:39:00 PDT

Comment on attachment 429714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429714&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6635
> +    Optional<Locker<Lock>> audioSourceNodeLocker;

In new code you should write std::optional, not Optional.

Comment 3 Chris Dumez 2021-05-25 22:00:55 PDT

Committed r278077 (238156@main): <https://commits.webkit.org/238156@main>

Comment 4 Radar WebKit Bug Importer 2021-05-25 22:01:21 PDT

<rdar://problem/78494211>