Bug 226235
Summary: | Warn when running build-webkit with unaligned Xcode release | ||
---|---|---|---|
Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | ap, ddkilzer, dvpdiner2, jbedard, mike, svillar, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=232606 https://bugs.webkit.org/show_bug.cgi?id=262087 |
Sam Sneddon [:gsnedders]
We don't have any bots checking e.g. Xcode 12 (macOS 11 aligned release) building with the macOS 10.15 SDK and typically such configurations fail. We should make build-webkit fail and document this so people stop questioning what they're missing when they run into build errors.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Xcode 12 with the macOS 10.15 SDK is not a configuration that can be installed directly, this can only happen through hacking pieces together manually.
There is a related issue that you may have had in mind though. Installing Xcode 12 with its macOS 11 SDK on macOS 10.15.x is in fact normal, and that's what we don't test for in CI at all.
Sam Sneddon [:gsnedders]
Oh, I thought installing Xcode from the Mac App Store always installed the SDK for the currently installed OS as well as potentially any newer OS SDK!
Regardless, the fundamental problem here is that we neither support nor document our lack of support for misaligned OS/Xcode releases.
Alexey Proskuryakov
Yes, this is definitely a problem. It is super painful, because we should support this very reasonable configuration that people may already have on their machines, but it would be costly because we don't need it for anything that ships.
As long as we don't support it, warning makes sense, and it would also be helpful to have it explained at <https://webkit.org/build-tools/>.
Radar WebKit Bug Importer
<rdar://problem/78728355>
Darryl Pogue
*** Bug 232454 has been marked as a duplicate of this bug. ***
Sergio Villar Senin
I am unable to build at the moment with MacOS 11.6 and Xcode 12.2 which from what I've read should be supported. This is what I get
In file included from /Users/svillar/WebKit/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:37:
/Users/svillar/WebKit/WebKitBuild/Debug/usr/local/include/pal/cocoa/AVFoundationSoftLink.h:51:33: error: 'AVDelegatingPlaybackCoordinator' is only available on macOS
12.0 or newer [-Werror,-Wunguarded-availability-new]
SOFT_LINK_CLASS_FOR_HEADER(PAL, AVDelegatingPlaybackCoordinator)
^
In file included from /Users/svillar/WebKit/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:37:
In file included from /Users/svillar/WebKit/WebKitBuild/Debug/usr/local/include/pal/cocoa/AVFoundationSoftLink.h:30:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVFoundat
ion.h:13:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVFCore.h
:56:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVPlaybackCoordinator.h:315:12:
note:
'AVDelegatingPlaybackCoordinator' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0
@interface AVDelegatingPlaybackCoordinator : AVPlaybackCoordinator
Alexey Proskuryakov
This log says that you have macOS 12 SDK, but Xcode 12.2 wouldn't include that. Did you copy the SDK manually into it, or do you actually have Xcode 13, the newest?
Sergio Villar Senin
(In reply to Alexey Proskuryakov from comment #7)
> This log says that you have macOS 12 SDK, but Xcode 12.2 wouldn't include
> that. Did you copy the SDK manually into it, or do you actually have Xcode
> 13, the newest?
Yep, sorry for the noise. I actually have both, so I guess the xcode-select will make the trick. Do you know if this is a global or per-user setting?
Alexey Proskuryakov
Sorry, I do not know that.
Sam Sneddon [:gsnedders]
*** Bug 232606 has been marked as a duplicate of this bug. ***