Bug 226234

Summary: [run-webkit-tests] Use webkitcorepy's TaskPool
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, ews-watchlist, glenn, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226236
https://bugs.webkit.org/show_bug.cgi?id=226238
https://bugs.webkit.org/show_bug.cgi?id=226344
https://bugs.webkit.org/show_bug.cgi?id=226506
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jonathan Bedard 2021-05-25 12:56:01 PDT 
In order to support Python 3, run-webkit-tests needs to use webkitcorepy's TaskPool for multiprocessing.
Comment 1 Radar WebKit Bug Importer 2021-05-25 12:56:39 PDT 
<rdar://problem/78471695>
Comment 2 Jonathan Bedard 2021-06-02 14:34:34 PDT 
Created attachment 430407 [details]
Patch
Comment 3 Jonathan Bedard 2021-06-02 16:42:33 PDT 
Created attachment 430418 [details]
Patch
Comment 4 dewei_zhu 2021-06-03 14:52:16 PDT 
Comment on attachment 430418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430418&action=review

r=me

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:154
> +        self.printer.write_update('Starting %s ...' % pluralize(num_workers, "worker"))

Use formatted string?
Comment 5 Jonathan Bedard 2021-06-03 15:01:27 PDT 
Created attachment 430503 [details]
Patch
Comment 6 EWS 2021-06-04 07:04:42 PDT 
Committed r278454 (238474@main): <https://commits.webkit.org/238474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430503 [details].