Bug 226225

Summary: [AppleWin] JSC fails to build
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2021-05-25 10:08:10 PDT
JSC fails to build on AppleWin with the following error: /usr/bin/ruby: No such file or directory -- include/private/WTF/Scripts/generate-unified-source-bundles. rb (LoadError)
Attachments
Patch (1.46 KB, patch)
2021-05-25 10:12 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-05-25 10:08:30 PDT
<rdar://78330435>
Per Arne Vollan
Comment 2 2021-05-25 10:12:29 PDT
Created attachment 429663 [details] Patch
Brent Fulgham
Comment 3 2021-05-25 11:08:23 PDT
Comment on attachment 429663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429663&action=review r=me > Source/WTF/wtf/CMakeLists.txt:-588 > -) It seems like you could keep this variable and leave the COPY command as it is, with the only change being the command to create the directory (and the new log message).
Per Arne Vollan
Comment 4 2021-05-25 11:39:53 PDT
(In reply to Brent Fulgham from comment #3) > Comment on attachment 429663 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429663&action=review > > r=me > > > Source/WTF/wtf/CMakeLists.txt:-588 > > -) > > It seems like you could keep this variable and leave the COPY command as it > is, with the only change being the command to create the directory (and the > new log message). That is a good point. This change is basically a revert of a recent change, so I was thinking we could try this out, in case that recent change introduced the issue. Thanks for reviewing!
EWS
Comment 5 2021-05-25 12:12:29 PDT
Committed r278032 (238129@main): <https://commits.webkit.org/238129@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429663 [details].
Note You need to log in before you can comment on or make changes to this bug.