| Summary: | Stop using UncheckedLock in DatabaseTracker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, darin, ggaren, kkinnunen, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2021-05-24 19:32:36 PDT
Created attachment 429613 [details]
Patch
Comment on attachment 429613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429613&action=review > Source/WebCore/ChangeLog:14 > + In this particular instance, I have opted to annotate the functions that gave out > + warning with WTF_IGNORES_THREAD_SAFETY_ANALYSIS. I initially tried to use proper > + annotations (WTF_ACQUIRES_LOCK() / WTF_RELEASES_LOCK()). However, the call sites are > + Objective C functions and I am unable to annotate those. I think adding a comment to the code explaining this would be helpful for future readers. Created attachment 429619 [details]
Patch
Committed r278008 (238121@main): <https://commits.webkit.org/238121@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429619 [details]. |