Bug 226208

Summary: Stop using UncheckedLock in DatabaseTracker
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-05-24 19:32:36 PDT
Stop using UncheckedLock in DatabaseTracker.
Attachments
Patch (3.30 KB, patch)
2021-05-24 19:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.62 KB, patch)
2021-05-24 20:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-24 19:35:43 PDT
Created attachment 429613 [details] Patch
Sam Weinig
Comment 2 2021-05-24 20:11:20 PDT
Comment on attachment 429613 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429613&action=review > Source/WebCore/ChangeLog:14 > + In this particular instance, I have opted to annotate the functions that gave out > + warning with WTF_IGNORES_THREAD_SAFETY_ANALYSIS. I initially tried to use proper > + annotations (WTF_ACQUIRES_LOCK() / WTF_RELEASES_LOCK()). However, the call sites are > + Objective C functions and I am unable to annotate those. I think adding a comment to the code explaining this would be helpful for future readers.
Chris Dumez
Comment 3 2021-05-24 20:13:50 PDT
Created attachment 429619 [details] Patch
EWS
Comment 4 2021-05-25 08:26:54 PDT
Committed r278008 (238121@main): <https://commits.webkit.org/238121@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429619 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-25 08:27:19 PDT
<rdar://problem/78457503>
Note You need to log in before you can comment on or make changes to this bug.