Bug 226199

Summary: [iOS] Adjust meaningful click heuristic to detect focus changes and editable content
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Wenson Hsieh
Reported 2021-05-24 16:50:28 PDT
rdar://78368624
Attachments
Patch (2.67 KB, patch)
2021-05-24 17:00 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (7.04 KB, patch)
2021-05-24 17:01 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (6.78 KB, patch)
2021-05-24 17:18 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-05-24 17:00:42 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-05-24 17:01:37 PDT
Created attachment 429595 [details] Patch
Tim Horton
Comment 3 2021-05-24 17:04:18 PDT
Comment on attachment 429595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429595&action=review > Source/WebKit/ChangeLog:16 > + Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately > + dismissing the keyboard after the tap. This feels a bit like tuning the heuristic to a particular use of it, instead of something that would actually make the click non-meaningful?
Wenson Hsieh
Comment 4 2021-05-24 17:08:29 PDT
(In reply to Tim Horton from comment #3) > Comment on attachment 429595 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429595&action=review > > > Source/WebKit/ChangeLog:16 > > + Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately > > + dismissing the keyboard after the tap. > > This feels a bit like tuning the heuristic to a particular use of it, > instead of something that would actually make the click non-meaningful? That's true! I'll remove this bit.
Wenson Hsieh
Comment 5 2021-05-24 17:18:34 PDT
Created attachment 429597 [details] Patch
EWS
Comment 6 2021-05-24 20:04:32 PDT
Committed r277990 (238103@main): <https://commits.webkit.org/238103@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429597 [details].
Note You need to log in before you can comment on or make changes to this bug.