Bug 226199

Summary: [iOS] Adjust meaningful click heuristic to detect focus changes and editable content
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Wenson Hsieh 2021-05-24 16:50:28 PDT 
rdar://78368624
Comment 1 Wenson Hsieh 2021-05-24 17:00:42 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-05-24 17:01:37 PDT 
Created attachment 429595 [details]
Patch
Comment 3 Tim Horton 2021-05-24 17:04:18 PDT 
Comment on attachment 429595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429595&action=review

> Source/WebKit/ChangeLog:16
> +        Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately
> +        dismissing the keyboard after the tap.

This feels a bit like tuning the heuristic to a particular use of it, instead of something that would actually make the click non-meaningful?
Comment 4 Wenson Hsieh 2021-05-24 17:08:29 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 429595 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429595&action=review
> 
> > Source/WebKit/ChangeLog:16
> > +        Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately
> > +        dismissing the keyboard after the tap.
> 
> This feels a bit like tuning the heuristic to a particular use of it,
> instead of something that would actually make the click non-meaningful?

That's true! I'll remove this bit.
Comment 5 Wenson Hsieh 2021-05-24 17:18:34 PDT 
Created attachment 429597 [details]
Patch
Comment 6 EWS 2021-05-24 20:04:32 PDT 
Committed r277990 (238103@main): <https://commits.webkit.org/238103@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429597 [details].