Bug 226197

Summary: [PlayStation] Implement FileSystem without std::filesystem
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Web Template FrameworkAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, chris.reid, cmarcelo, darin, ews-watchlist, ggaren, gyuyoung.kim, ryuan.choi, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
cdumez: review+
Patch none

Don Olmstead
Reported 2021-05-24 16:19:24 PDT
The PlayStation 4 doesn't have std::filesystem support currently so bring back the POSIX implementations.
Attachments
Patch (19.41 KB, patch)
2021-05-24 16:32 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (19.42 KB, patch)
2021-05-24 16:38 PDT, Don Olmstead 		cdumez: review+
DetailsFormatted DiffDiff
Patch (19.31 KB, patch)
2021-05-25 08:37 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-05-24 16:32:15 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2021-05-24 16:38:01 PDT
Created attachment 429589 [details] Patch Make style checker happy
Christopher Reid
Comment 3 2021-05-24 16:52:34 PDT
Comment on attachment 429588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429588&action=review Just have an informal comment > Source/WTF/wtf/playstation/FileSystemPlayStation.cpp:38 > +#include <fnmatch.h> fnmatch.h looks like it isn't needed now
Chris Dumez
Comment 4 2021-05-24 16:54:13 PDT
Comment on attachment 429589 [details] Patch r=me if the bots are happy.
Don Olmstead
Comment 5 2021-05-25 08:37:09 PDT
Created attachment 429654 [details] Patch Added implementation for isHidden and got rid of unused includes.
EWS
Comment 6 2021-05-25 10:34:11 PDT
Committed r278027 (238124@main): <https://commits.webkit.org/238124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429654 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-25 10:35:22 PDT
<rdar://problem/78464748>
Note You need to log in before you can comment on or make changes to this bug.