Bug 226196

Summary:

When running with --reportTotalPhaseTimes=1, we should also log the max time in a phase

Product:

WebKit

Reporter:

Robin Morisset <rmorisset>

Component:

JavaScriptCore

Assignee:

Robin Morisset <rmorisset>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Robin Morisset 2021-05-24 16:11:04 PDT

When seeing that we spend a lot of time in a given phase, it can be helpful to know whether it is because of an outlier or not.
It matters especially for the DFG, as the GC is stopped whenever a DFG phase is running.

Comment 1 Robin Morisset 2021-05-24 16:13:28 PDT

Created attachment 429584 [details]
Patch

Comment 2 EWS 2021-05-24 17:03:54 PDT

Committed r277984 (238097@main): <https://commits.webkit.org/238097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429584 [details].

Comment 3 Radar WebKit Bug Importer 2021-05-24 17:04:34 PDT

<rdar://problem/78426364>