Bug 226191

Summary: Stop using UncheckedLock in Node's s_eventTargetDataMapLock
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, esprehn+autocc, ews-watchlist, ggaren, kangil.han, kkinnunen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-05-24 15:19:59 PDT
Stop using UncheckedLock in Node's s_eventTargetDataMapLock. This is a step towards phasing out UncheckedLock in favor of Lock which supports Clang Thread Safety Analysis.
Attachments
Patch (2.06 KB, patch)
2021-05-24 15:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-24 15:21:44 PDT
Created attachment 429574 [details] Patch
Chris Dumez
Comment 2 2021-05-25 15:59:21 PDT
ping review? I'd love to make some progress phasing out UncheckedLock.
Geoffrey Garen
Comment 3 2021-05-25 16:00:25 PDT
Comment on attachment 429574 [details] Patch r=me
EWS
Comment 4 2021-05-25 16:19:52 PDT
Committed r278058 (238142@main): <https://commits.webkit.org/238142@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429574 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-25 16:22:50 PDT
<rdar://problem/78482128>
Note You need to log in before you can comment on or make changes to this bug.