Bug 226191 - Stop using UncheckedLock in Node's s_eventTargetDataMapLock
Summary: Stop using UncheckedLock in Node's s_eventTargetDataMapLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 15:19 PDT by Chris Dumez
Modified: 2021-05-25 16:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2021-05-24 15:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-24 15:19:59 PDT 
Stop using UncheckedLock in Node's s_eventTargetDataMapLock. This is a step towards phasing out UncheckedLock in favor of Lock which supports Clang Thread Safety Analysis.
Comment 1 Chris Dumez 2021-05-24 15:21:44 PDT 
Created attachment 429574 [details]
Patch
Comment 2 Chris Dumez 2021-05-25 15:59:21 PDT 
ping review? I'd love to make some progress phasing out UncheckedLock.
Comment 3 Geoffrey Garen 2021-05-25 16:00:25 PDT 
Comment on attachment 429574 [details]
Patch

r=me
Comment 4 EWS 2021-05-25 16:19:52 PDT 
Committed r278058 (238142@main): <https://commits.webkit.org/238142@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429574 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-25 16:22:50 PDT 
<rdar://problem/78482128>