Bug 226184

Summary: Remove deprecated API usage in PageClientImplMac
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dana.estra, hi, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Removed deprecated API usage in PageClientImplMac and implemented edit from review none

Aditya Keerthi
Reported 2021-05-24 12:33:52 PDT
`[NSWindow convertScreenToBase:]` and `[NSWindow convertBaseToScreen:]` have been deprecated since macOS 10.7.
Attachments
Patch (1.92 KB, patch)
2021-05-24 14:03 PDT, Dana Estra 		no flags
DetailsFormatted DiffDiff
Removed deprecated API usage in PageClientImplMac and implemented edit from review (1.91 KB, patch)
2021-05-24 15:48 PDT, Dana Estra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Estra
Comment 1 2021-05-24 14:03:46 PDT
Created attachment 429561 [details] Patch
Devin Rousso
Comment 2 2021-05-24 14:17:32 PDT
Comment on attachment 429561 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429561&action=review r=me, nice! > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:447 > + NSPoint windowCoord = [[m_view window] convertPointFromScreen:point]; NIT: I think you can `m_view.window` :) > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:455 > + tempRect.origin = [[m_view window] convertPointToScreen:tempRect.origin]; ditto (:447)
Dana Estra
Comment 3 2021-05-24 15:48:59 PDT
Created attachment 429579 [details] Removed deprecated API usage in PageClientImplMac and implemented edit from review
EWS
Comment 4 2021-05-24 16:47:35 PDT
Committed r277983 (238096@main): <https://commits.webkit.org/238096@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429579 [details].
Radar WebKit Bug Importer
Comment 5 2021-05-24 16:48:20 PDT
<rdar://problem/78425683>
Note You need to log in before you can comment on or make changes to this bug.