Bug 226180

Summary: Allow CTI stubs to be generated off the main thread
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 226096    
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing
saam: commit-queue-
[fast-cq] patch for landing none

Saam Barati
Reported 2021-05-24 10:33:00 PDT
...
Attachments
patch (23.74 KB, patch)
2021-05-24 12:57 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (24.25 KB, patch)
2021-05-24 15:20 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] patch for landing (24.25 KB, patch)
2021-05-24 15:32 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-05-24 12:57:09 PDT
Created attachment 429554 [details] patch
Mark Lam
Comment 2 2021-05-24 14:18:12 PDT
Comment on attachment 429554 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=429554&action=review r=me > Source/JavaScriptCore/jit/JITThunks.cpp:138 > + if (entry.needsCrossModifyingCodeFence && !isCompilationThread()) { Can you add a comment here as to why compilation threads don't need the crossModifyingCodeFence? It isn't obvious from reading this section of code.
Saam Barati
Comment 3 2021-05-24 15:20:16 PDT
Created attachment 429573 [details] patch for landing
Saam Barati
Comment 4 2021-05-24 15:32:51 PDT
Created attachment 429575 [details] [fast-cq] patch for landing
EWS
Comment 5 2021-05-24 15:34:27 PDT
Committed r277974 (238095@main): <https://commits.webkit.org/238095@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429575 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-24 15:35:47 PDT
<rdar://problem/78422315>
Note You need to log in before you can comment on or make changes to this bug.