| Summary: | Allow CTI stubs to be generated off the main thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 226096 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Saam Barati
2021-05-24 10:33:00 PDT
Created attachment 429554 [details]
patch
Comment on attachment 429554 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=429554&action=review r=me > Source/JavaScriptCore/jit/JITThunks.cpp:138 > + if (entry.needsCrossModifyingCodeFence && !isCompilationThread()) { Can you add a comment here as to why compilation threads don't need the crossModifyingCodeFence? It isn't obvious from reading this section of code. Created attachment 429573 [details]
patch for landing
Created attachment 429575 [details]
[fast-cq] patch for landing
Committed r277974 (238095@main): <https://commits.webkit.org/238095@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429575 [details]. |