Bug 226180 - Allow CTI stubs to be generated off the main thread
Summary: Allow CTI stubs to be generated off the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 226096
  Show dependency tree / graph
 
Reported: 2021-05-24 10:33 PDT by Saam Barati
Modified: 2021-05-24 15:35 PDT (History)
6 users (show)

See Also:

Attachments
patch (23.74 KB, patch)
2021-05-24 12:57 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (24.25 KB, patch)
2021-05-24 15:20 PDT, Saam Barati 		saam: commit-queue-
Details | Formatted Diff | Diff
[fast-cq] patch for landing (24.25 KB, patch)
2021-05-24 15:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-05-24 10:33:00 PDT 
...
Comment 1 Saam Barati 2021-05-24 12:57:09 PDT 
Created attachment 429554 [details]
patch
Comment 2 Mark Lam 2021-05-24 14:18:12 PDT 
Comment on attachment 429554 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429554&action=review

r=me

> Source/JavaScriptCore/jit/JITThunks.cpp:138
> +        if (entry.needsCrossModifyingCodeFence && !isCompilationThread()) {

Can you add a comment here as to why compilation threads don't need the crossModifyingCodeFence?  It isn't obvious from reading this section of code.
Comment 3 Saam Barati 2021-05-24 15:20:16 PDT 
Created attachment 429573 [details]
patch for landing
Comment 4 Saam Barati 2021-05-24 15:32:51 PDT 
Created attachment 429575 [details]
[fast-cq] patch for landing
Comment 5 EWS 2021-05-24 15:34:27 PDT 
Committed r277974 (238095@main): <https://commits.webkit.org/238095@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429575 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-24 15:35:47 PDT 
<rdar://problem/78422315>