Bug 226162

Summary: Putting HashMap in a heap block hurts memory use, speed, code size (part 1)
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, berto, cdumez, cgarcia, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, gustavo, gyuyoung.kim, jamesr, japhet, jfernandez, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, msaboff, pdr, rego, saam, simon.fraser, svillar, tonikitoo, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 226068    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Darin Adler
Reported 2021-05-23 23:10:04 PDT
Putting HashMap in a heap block hurts memory use, speed, and code size. We should stop doing that. This bug will cover removing *most* cases where we do it.
Attachments
Patch (255.73 KB, patch)
2021-05-23 23:17 PDT, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (255.74 KB, patch)
2021-05-23 23:31 PDT, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-05-23 23:17:02 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 2 2021-05-23 23:18:05 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Darin Adler
Comment 3 2021-05-23 23:31:18 PDT
Created attachment 429506 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-05-30 23:11:17 PDT
<rdar://problem/78675956>
Darin Adler
Comment 5 2025-07-12 20:48:12 PDT
Pull request: https://github.com/WebKit/WebKit/pull/47945
EWS
Comment 6 2025-07-21 20:34:20 PDT
Committed 297725@main (0c95ee27a86e): <https://commits.webkit.org/297725@main> Reviewed commits have been landed. Closing PR #47945 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.