Bug 226155

Summary: Remove some now invalid tests in testmasm.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Description Mark Lam 2021-05-23 08:35:34 PDT 
The ARM64E tests were checking that cageConditionallyAndUntag() would fail to produce a caged pointer if fed invalid values.  These tests are no longer feasible because on ARM64E, feeding cageConditionallyAndUntag() invalid values will now result in a crash.  This patch removes these tests.
Comment 1 Mark Lam 2021-05-23 08:38:18 PDT 
Created attachment 429465 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-05-23 21:21:20 PDT 
Comment on attachment 429465 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review

r=me

> Source/JavaScriptCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :)
Comment 3 Mark Lam 2021-05-23 21:53:02 PDT 
Comment on attachment 429465 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:6
>> +        Reviewed by NOBODY (OOPS!).
> 
> Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :)

Oops.  Will do.
Comment 4 Mark Lam 2021-05-23 22:00:18 PDT 
Landed in r277942: <http://trac.webkit.org/r277942>.
Comment 5 Radar WebKit Bug Importer 2021-05-23 22:01:21 PDT 
<rdar://problem/78384961>