Bug 226150

Summary: [LFC] Add support for geometry/quirks virtual functions
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

zalan
Reported 2021-05-22 21:15:45 PDT
ssia
Attachments
Patch (86.39 KB, patch)
2021-05-22 21:18 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (49.27 KB, patch)
2021-05-23 07:06 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (77.22 KB, patch)
2021-05-24 12:59 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2021-05-22 21:18:07 PDT
Created attachment 429452 [details] Patch
zalan
Comment 2 2021-05-23 07:06:27 PDT
Created attachment 429461 [details] Patch
Antti Koivisto
Comment 3 2021-05-24 10:08:29 PDT
Comment on attachment 429461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429461&action=review > Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.h:59 > + const FormattingGeometry& formattingGeometry() const final { return m_blockFormattingGeometry; } > + const FormattingQuirks& formattingQuirks() const final { return m_blockFormattingQuirks; } I think you could just return BlockFormattingFoo& here and remove the specialised versions. You can override with more narrow type.
zalan
Comment 4 2021-05-24 12:59:16 PDT
Created attachment 429555 [details] Patch
EWS
Comment 5 2021-05-24 15:30:17 PDT
Committed r277972 (238094@main): <https://commits.webkit.org/238094@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429555 [details].
Radar WebKit Bug Importer
Comment 6 2021-05-24 15:31:24 PDT
<rdar://problem/78422093>
Note You need to log in before you can comment on or make changes to this bug.