Bug 226137

Summary: Remove StringBuilder::appendLiteral
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, allan.jensen, apinheiro, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gustavo, gyuyoung.kim, hi, jamesr, japhet, jcraig, jdiggs, jer.noble, jfernandez, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mkwst, msaboff, pdr, philipj, rego, saam, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, svillar, tonikitoo, toyoshim, tzagallo, webkit-bug-importer, yutak
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Darin Adler 2021-05-21 23:07:53 PDT
Remove StringBuilder::appendLiteral
Comment 1 Darin Adler 2021-05-22 00:57:08 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2021-05-22 12:21:26 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2021-05-22 12:22:24 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Darin Adler 2021-05-23 15:48:37 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2021-05-23 22:06:22 PDT
Created attachment 429501 [details]
Patch
Comment 6 Chris Dumez 2021-05-24 08:33:58 PDT
Comment on attachment 429501 [details]
Patch

r=me
Comment 7 Sam Weinig 2021-05-24 09:17:34 PDT
Nice!
Comment 8 EWS 2021-05-24 14:51:57 PDT
Committed r277967 (238091@main): <https://commits.webkit.org/238091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429501 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-24 14:53:23 PDT
<rdar://problem/78420303>