Bug 226137

Summary:

Remove StringBuilder::appendLiteral

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, alecflett, allan.jensen, apinheiro, beidson, benjamin, berto, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, dino, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gustavo, gyuyoung.kim, hi, jamesr, japhet, jcraig, jdiggs, jer.noble, jfernandez, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mkwst, msaboff, pdr, philipj, rego, saam, sabouhallawa, samuel_white, sam, schenney, sergio, simon.fraser, svillar, tonikitoo, toyoshim, tzagallo, webkit-bug-importer, yutak

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Darin Adler

Reported 2021-05-21 23:07:53 PDT

Remove StringBuilder::appendLiteral

Attachments
Patch (312.26 KB, patch) 2021-05-22 00:57 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (346.33 KB, patch) 2021-05-22 12:21 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (349.52 KB, patch) 2021-05-23 15:48 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (349.83 KB, patch) 2021-05-23 22:06 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2021-05-22 00:57:08 PDT Comment hidden (obsolete)

Created attachment 429409 [details] Patch

Darin Adler

Comment 2 2021-05-22 12:21:26 PDT Comment hidden (obsolete)

Created attachment 429422 [details] Patch

EWS Watchlist

Comment 3 2021-05-22 12:22:24 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Darin Adler

Comment 4 2021-05-23 15:48:37 PDT Comment hidden (obsolete)

Created attachment 429481 [details] Patch

Darin Adler

Comment 5 2021-05-23 22:06:22 PDT

Created attachment 429501 [details] Patch

Chris Dumez

Comment 6 2021-05-24 08:33:58 PDT

Comment on attachment 429501 [details] Patch r=me

Sam Weinig

Comment 7 2021-05-24 09:17:34 PDT

Nice!