Bug 226133

Summary:

Replace LockHolder with Locker in local variables

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, aboxhall, achristensen, apinheiro, benjamin, berto, calvaris, cfleizach, cgarcia, cmarcelo, commit-queue, darin, ddkilzer, dmazzoni, eric.carlson, ews-watchlist, fred.wang, galpeter, ggaren, glenn, gustavo, gyuyoung.kim, hi, hta, jamesr, jcraig, jdiggs, jer.noble, joepeck, keith_miller, kkinnunen, kondapallykalyan, luiz, mark.lam, menard, msaboff, philipj, pnormand, ryuan.choi, saam, samuel_white, sam, sergio, tommyw, tonikitoo, tzagallo, vjaquez, webkit-bug-importer, zeno

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://en.cppreference.com/w/cpp/language/class_template_argument_deduction

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226139

Bug Depends on:

226140

Bug Blocks:

226138

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Description Chris Dumez 2021-05-21 20:04:43 PDT

Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker<T>.

Comment 1 Chris Dumez 2021-05-21 20:12:26 PDT

Created attachment 429393 [details]
Patch

Comment 2 EWS Watchlist 2021-05-21 20:13:27 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Chris Dumez 2021-05-21 20:20:14 PDT

Created attachment 429396 [details]
Patch

Comment 4 Chris Dumez 2021-05-21 21:16:50 PDT

Created attachment 429397 [details]
Patch

Comment 5 Chris Dumez 2021-05-21 21:38:11 PDT

Created attachment 429398 [details]
Patch

Comment 6 Chris Dumez 2021-05-21 22:49:29 PDT

Comment on attachment 429398 [details]
Patch

Clearing flags on attachment: 429398

Committed r277913 (238046@main): <https://commits.webkit.org/238046@main>

Comment 7 Chris Dumez 2021-05-21 22:49:34 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2021-05-21 22:50:18 PDT

<rdar://problem/78343441>

Comment 9 WebKit Commit Bot 2021-05-22 04:13:40 PDT

Re-opened since this is blocked by bug 226140

Comment 10 Aakash Jain 2021-05-22 04:34:42 PDT

(In reply to Chris Dumez from comment #6)
> Committed r277913 (238046@main): <https://commits.webkit.org/238046@main>
This caused 50+ layout-test crashes in debug mode.
e.g.: https://build.webkit.org/results/Apple-BigSur-Debug-AppleSilicon-WK1-Tests/r277913%20(1673)/accessibility/accessibility-crash-focused-element-change-crash-log.txt

Comment 11 Chris Dumez 2021-05-22 08:30:15 PDT

Created attachment 429412 [details]
Patch

Comment 12 Chris Dumez 2021-05-22 09:49:54 PDT

Comment on attachment 429412 [details]
Patch

Clearing flags on attachment: 429412

Committed r277920 (238053@main): <https://commits.webkit.org/238053@main>

Comment 13 Chris Dumez 2021-05-22 09:49:59 PDT

All reviewed patches have been landed.  Closing bug.