Bug 226129

Summary: Fix locking issue for AudioDestinationCocoa::m_isPlaying
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-05-21 18:14:32 PDT
Fix locking issue for AudioDestinationCocoa::m_isPlaying. The AudioDestinationCocoa::isPlaying() getter fails to lock. isPlaying() may get called from the main thread and the audio rendering thread.
Attachments
Patch (2.89 KB, patch)
2021-05-21 18:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.89 KB, patch)
2021-05-21 20:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-21 18:18:29 PDT
Created attachment 429381 [details] Patch
Chris Dumez
Comment 2 2021-05-21 20:14:10 PDT
Created attachment 429394 [details] Patch
EWS
Comment 3 2021-05-21 21:24:32 PDT
Committed r277910 (238043@main): <https://commits.webkit.org/238043@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429394 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-21 21:25:20 PDT
<rdar://problem/78342090>
Note You need to log in before you can comment on or make changes to this bug.