Bug 226128

Summary: [Cocoa] Hang in WebM format reader when loading content from https://powerrangers.fandom.com/
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, kkinnunen, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226217
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing
jer.noble: commit-queue-
Patch for landing none

Jer Noble
Reported 2021-05-21 17:04:59 PDT
[Cocoa] Hang in WebM format reader when loading content from https://powerrangers.fandom.com/
Attachments
Patch (3.07 KB, patch)
2021-05-21 17:09 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (3.10 KB, patch)
2021-05-21 17:18 PDT, Jer Noble 		jer.noble: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (5.03 KB, patch)
2021-05-28 09:38 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-05-21 17:05:31 PDT
<rdar://77645877>
Jer Noble
Comment 2 2021-05-21 17:09:07 PDT
Created attachment 429371 [details] Patch
Jer Noble
Comment 3 2021-05-21 17:18:54 PDT
Created attachment 429375 [details] Patch for landing
Kimmo Kinnunen
Comment 4 2021-05-25 04:53:33 PDT
Immediately after the lines that query these properties are queries for other properties. The hangs cannot most likely be solved like this. Bug 226217 should contain the general purpose test case to solve.
Jer Noble
Comment 5 2021-05-27 15:08:56 PDT
(In reply to Kimmo Kinnunen from comment #4) > Immediately after the lines that query these properties are queries for > other properties. The hangs cannot most likely be solved like this. The only property we support querying for is `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of what property they query for, unless it's Duration, we won't block.
Kimmo Kinnunen
Comment 6 2021-05-27 23:00:10 PDT
(In reply to Jer Noble from comment #5) > The only property we support querying for is > `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of > what property they query for, unless it's Duration, we won't block. I mean: track array blocks, stuff inside tracks block...
Jer Noble
Comment 7 2021-05-28 09:38:08 PDT
Created attachment 430020 [details] Patch for landing
Jer Noble
Comment 8 2021-05-28 09:39:26 PDT
(In reply to Kimmo Kinnunen from comment #6) > (In reply to Jer Noble from comment #5) > > The only property we support querying for is > > `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of > > what property they query for, unless it's Duration, we won't block. > > I mean: track array blocks, stuff inside tracks block... Right, we have to systematically remove sources of deadlocks; this is just one of them.
EWS
Comment 9 2021-05-28 13:13:43 PDT
Committed r278223 (238261@main): <https://commits.webkit.org/238261@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430020 [details].
Note You need to log in before you can comment on or make changes to this bug.