Bug 226127

Summary: Stop using holdLock() in WebKit/WebKitLegacy/Tools as it is not compatible with Clang thread safety analysis
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cmarcelo, darin, ddkilzer, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jbedard, jer.noble, kkinnunen, luiz, philipj, ryuan.choi, sam, sergio, webkit-bug-importer, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226116
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-05-21 16:46:14 PDT
Stop using holdLock() in WebKit/WebKitLegacy/Tools as it is not compatible with Clang thread safety analysis.
Attachments
Patch (39.73 KB, patch)
2021-05-21 16:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (39.72 KB, patch)
2021-05-21 17:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-21 16:47:40 PDT
Created attachment 429363 [details] Patch
Chris Dumez
Comment 2 2021-05-21 17:01:54 PDT
Created attachment 429366 [details] Patch
EWS
Comment 3 2021-05-21 21:34:15 PDT
Committed r277911 (238044@main): <https://commits.webkit.org/238044@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429366 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-21 21:35:15 PDT
<rdar://problem/78342209>
Note You need to log in before you can comment on or make changes to this bug.