Bug 226120

Summary:

All Netflix playback fails after r277740

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Web Template Framework

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=225920

Attachments:

Description	Flags
Patch	none

Description Eric Carlson 2021-05-21 16:16:04 PDT

All Netflix playback fails with error S7399-1260 after r277740

Comment 1 Radar WebKit Bug Importer 2021-05-21 16:19:19 PDT

<rdar://problem/78333782>

Comment 2 Sam Weinig 2021-05-21 18:04:55 PDT

I think I spotted the issue. Missing ! in CDMInstanceFairPlayStreamingAVFObjC.mm:

             auto keyIDVector = base64Decode(keyIDString);
-            if (keyIDVector)
+            if (!keyIDVector)
                 return false;

Testing a fix now.

Comment 3 Sam Weinig 2021-05-21 18:35:34 PDT

Created attachment 429382 [details]
Patch

Comment 4 Sam Weinig 2021-05-21 18:36:06 PDT

Is there anyway to test this code path currently?

Comment 5 EWS 2021-05-21 19:07:24 PDT

Committed r277905 (238038@main): <https://commits.webkit.org/238038@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429382 [details].