Bug 226115

Summary: [test-lldb-webkit] Update for Xcode 12.5
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, darin, jenner, ryanhaddad, simon.fraser, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2021-05-21 15:27:30 PDT
We need to make some changes to test-lldb-webkit to support Xcode 12.5 (and Python 3)
Attachments
Patch (5.57 KB, patch)
2021-05-21 15:31 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.83 KB, patch)
2021-05-25 16:12 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-05-21 15:28:21 PDT
<rdar://problem/78331664>
Jonathan Bedard
Comment 2 2021-05-21 15:31:58 PDT
Created attachment 429351 [details] Patch
Alexey Proskuryakov
Comment 3 2021-05-21 15:57:26 PDT
Comment on attachment 429351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429351&action=review > Tools/ChangeLog:3 > + [test-lldb-webkit] Update for Xcode 12.5 Does this script continue to work on older OS versions? > Tools/lldb/dump_class_layout_unittest.py:321 > - +2 < 2> <PADDING: 2 bytes> > + +2 < 1> <PADDING: 1 bytes> This looks like a compiler change, not an lldb change. At the very least, we need comments updated in the .cpp counterpart, but really we need to understand what changed.
Jonathan Bedard
Comment 4 2021-05-21 16:13:17 PDT
(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 429351 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=429351&action=review > > > Tools/ChangeLog:3 > > + [test-lldb-webkit] Update for Xcode 12.5 > > Does this script continue to work on older OS versions? > > > Tools/lldb/dump_class_layout_unittest.py:321 > > - +2 < 2> <PADDING: 2 bytes> > > + +2 < 1> <PADDING: 1 bytes> > > This looks like a compiler change, not an lldb change. At the very least, we > need comments updated in the .cpp counterpart, but really we need to > understand what changed. The encoding bits should work fine, but the class layout will almost certainly fail with different compiler versions, yes.
Jonathan Bedard
Comment 5 2021-05-25 16:12:27 PDT
Created attachment 429706 [details] Patch
EWS
Comment 6 2021-05-26 08:23:57 PDT
Committed r278083 (238162@main): <https://commits.webkit.org/238162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429706 [details].
Note You need to log in before you can comment on or make changes to this bug.