Bug 226112

Summary: Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Sam Weinig 2021-05-21 14:14:30 PDT 
Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Comment 1 Sam Weinig 2021-05-21 14:19:43 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-05-21 14:21:54 PDT 
Created attachment 429341 [details]
Patch
Comment 3 Darin Adler 2021-05-21 15:51:05 PDT 
Comment on attachment 429341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429341&action=review

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:700
> +    auto propertyList = adoptCF(CGColorSpaceCopyPropertyList(colorSpace));
> +    encoder << CGColorSpaceEncodingScheme::PropertyList;
> +    encoder << propertyList;

No need for this local variable. Maybe we can write this?

    encoder << CGColorSpaceEncodingScheme::PropertyList << adoptCF(CGColorSpaceCopyPropertyList(colorSpace));
Comment 4 Sam Weinig 2021-05-21 17:18:47 PDT 
Created attachment 429374 [details]
Patch
Comment 5 Sam Weinig 2021-05-21 18:04:12 PDT 
Created attachment 429379 [details]
Patch
Comment 6 EWS 2021-05-21 19:23:50 PDT 
Committed r277906 (238039@main): <https://commits.webkit.org/238039@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429379 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-21 19:24:19 PDT 
<rdar://problem/78339484>