Bug 226112

Summary: Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Sam Weinig
Reported 2021-05-21 14:14:30 PDT
Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Attachments
Patch (55.59 KB, patch)
2021-05-21 14:19 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (55.54 KB, patch)
2021-05-21 14:21 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (56.19 KB, patch)
2021-05-21 17:18 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (56.16 KB, patch)
2021-05-21 18:04 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-21 14:19:43 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2021-05-21 14:21:54 PDT
Created attachment 429341 [details] Patch
Darin Adler
Comment 3 2021-05-21 15:51:05 PDT
Comment on attachment 429341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429341&action=review > Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:700 > + auto propertyList = adoptCF(CGColorSpaceCopyPropertyList(colorSpace)); > + encoder << CGColorSpaceEncodingScheme::PropertyList; > + encoder << propertyList; No need for this local variable. Maybe we can write this? encoder << CGColorSpaceEncodingScheme::PropertyList << adoptCF(CGColorSpaceCopyPropertyList(colorSpace));
Sam Weinig
Comment 4 2021-05-21 17:18:47 PDT
Created attachment 429374 [details] Patch
Sam Weinig
Comment 5 2021-05-21 18:04:12 PDT
Created attachment 429379 [details] Patch
EWS
Comment 6 2021-05-21 19:23:50 PDT
Committed r277906 (238039@main): <https://commits.webkit.org/238039@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429379 [details].
Radar WebKit Bug Importer
Comment 7 2021-05-21 19:24:19 PDT
<rdar://problem/78339484>
Note You need to log in before you can comment on or make changes to this bug.