Bug 226104

Summary: REGRESSION(r276993): 5 TestWebKitAPI.AudioRoutingArbitration (api-tests) are constant failures
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226787
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2021-05-21 13:00:57 PDT 
REGRESSION(r276993): 5 TestWebKitAPI.AudioRoutingArbitration (api-tests) are constant failures
Comment 1 Jer Noble 2021-05-21 13:01:15 PDT 
<rdar://77998049>
Comment 2 Jer Noble 2021-05-21 13:11:47 PDT 
Created attachment 429330 [details]
Patch
Comment 3 Jer Noble 2021-05-21 13:46:20 PDT 
Created attachment 429334 [details]
Patch
Comment 4 Jer Noble 2021-05-21 14:00:29 PDT 
Created attachment 429336 [details]
Patch
Comment 5 Jer Noble 2021-05-21 15:54:40 PDT 
Created attachment 429355 [details]
Patch
Comment 6 Jer Noble 2021-05-21 17:15:49 PDT 
Created attachment 429373 [details]
Patch for landing
Comment 7 Eric Carlson 2021-05-21 17:29:17 PDT 
Comment on attachment 429355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429355&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:291
> +    bool currentDataAvailable() const { return m_readyState >= MediaPlayer::ReadyState::HaveCurrentData; }

You probably didn't mean to include this :-)
Comment 8 Jer Noble 2021-06-02 09:01:33 PDT 
Created attachment 430366 [details]
Patch for landing
Comment 9 Jer Noble 2021-06-02 10:35:30 PDT 
Created attachment 430374 [details]
Patch for landing
Comment 10 EWS 2021-06-02 14:36:00 PDT 
Committed r278374 (238401@main): <https://commits.webkit.org/238401@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430374 [details].