Bug 226084

Summary: Accessibility caption styles does not always reflect the selection
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cfleizach, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2021-05-21 07:51:03 PDT 
This is caused by a race between pushing the caption preference value to the WebContent process and receiving the notification in that process.
Comment 1 Per Arne Vollan 2021-05-21 07:51:21 PDT 
<rdar://75426845>
Comment 2 Per Arne Vollan 2021-05-21 08:01:26 PDT 
Created attachment 429289 [details]
Patch
Comment 3 chris fleizach 2021-05-21 10:30:54 PDT 
Comment on attachment 429289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429289&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1107
> +        return;

we probably don't need a return here. the other if blocks don't have it
Comment 4 Per Arne Vollan 2021-05-21 10:39:10 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 429289 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429289&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1107
> > +        return;
> 
> we probably don't need a return here. the other if blocks don't have it

Will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-05-21 10:41:41 PDT 
Created attachment 429310 [details]
Patch
Comment 6 EWS 2021-05-21 12:04:47 PDT 
Committed r277874 (238012@main): <https://commits.webkit.org/238012@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429310 [details].